Skip to content

Conversation

@facchinm
Copy link
Contributor

@facchinm facchinm commented Aug 8, 2019

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change I requested in my previous review has been resolved. Thanks!

@sandeepmistry
Copy link
Contributor

For MKR Vidor 4000, should we document somewhere (maybe the read me) that sketches that contain bitstreams can't be used?

@facchinm
Copy link
Contributor Author

facchinm commented Aug 9, 2019

For MKR Vidor 4000, should we document somewhere (maybe the read me) that sketches that contain bitstreams can't be used?

The readme looks a good place for this info 👍

@per1234
Copy link
Contributor

per1234 commented Aug 9, 2019

I would prefer it to be documented in the library reference page. I think that will make the information more visible to the users:
https://www.arduino.cc/en/Reference/WiFi101OTA
That content will need to be updated anyway once this is merged.

@@ -0,0 +1,91 @@
/*
This example connects to an WPA encrypted WiFi network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This example connects to an WPA encrypted WiFi network.
This example connects to a WPA encrypted WiFi network.

/*
This example connects to an WPA encrypted WiFi network.
Then it prints the MAC address of the Wifi shield,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then it prints the MAC address of the Wifi shield,
Then it prints the MAC address of the WiFi shield,


// print the received signal strength:
long rssi = WiFi.RSSI();
Serial.print("signal strength (RSSI):");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Serial.print("signal strength (RSSI):");
Serial.print("signal strength (RSSI): ");

author=Arduino
maintainer=Arduino <[email protected]>
sentence=Update sketches on your board over WiFi
paragraph=Requires an Arduino/Genuino SAMD board

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should read "SAMD or MEGA AVR"

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants