Skip to content

Conversation

@pennam
Copy link
Collaborator

@pennam pennam commented Sep 8, 2022

The runtime-path input is deprecated. We should use runtime-paths instead. See :

@pennam pennam requested review from aentinger and per1234 September 8, 2022 15:35
@pennam
Copy link
Collaborator Author

pennam commented Sep 8, 2022

maybe I was too optimistic 😿

@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Sep 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #334 (1889902) into master (9673032) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files          27       27           
  Lines        1113     1113           
=======================================
  Hits         1056     1056           
  Misses         57       57           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pennam pennam merged commit 112ec82 into arduino-libraries:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants