Improve board-specific configuration system in compile-examples CI workflow #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflow Use the matrix.include key to customize the compile-examples CI workflow's matrix jobs with board type-specific configurations. This GitHub Actions feature allows defining additional properties for matrix jobs that match the filter. The previous approach for doing this was to use generated environment variable names, which worked but seemed likely to be confusing for anyone trying to decipher the workflow. I think the new approach is a little easier to understand and less hacky. I had hoped this would allow me to do away with the board.type system, but supplying lists of values to the filter keys isn't supported, you can't reference the env key from matrix, and YAML anchors aren't supported. So the board.type system remains the only way I can see to avoid redefining the configuration options for each board of the same type.
|
Memory usage change @18343c67c95c9a50fbda63a103bda9711a5ee3f4
|
aentinger
pushed a commit
that referenced
this pull request
May 13, 2020
…rkflow (#124) Use the matrix.include key to customize the compile-examples CI workflow's matrix jobs with board type-specific configurations. This GitHub Actions feature allows defining additional properties for matrix jobs that match the filter. The previous approach for doing this was to use generated environment variable names, which worked but seemed likely to be confusing for anyone trying to decipher the workflow. I think the new approach is a little easier to understand and less hacky. I had hoped this would allow me to do away with the board.type system, but supplying lists of values to the filter keys isn't supported, you can't reference the env key from matrix, and YAML anchors aren't supported. So the board.type system remains the only way I can see to avoid redefining the configuration options for each board of the same type.
aentinger
pushed a commit
that referenced
this pull request
May 13, 2020
…rkflow (#124) Use the matrix.include key to customize the compile-examples CI workflow's matrix jobs with board type-specific configurations. This GitHub Actions feature allows defining additional properties for matrix jobs that match the filter. The previous approach for doing this was to use generated environment variable names, which worked but seemed likely to be confusing for anyone trying to decipher the workflow. I think the new approach is a little easier to understand and less hacky. I had hoped this would allow me to do away with the board.type system, but supplying lists of values to the filter keys isn't supported, you can't reference the env key from matrix, and YAML anchors aren't supported. So the board.type system remains the only way I can see to avoid redefining the configuration options for each board of the same type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the matrix.include key to customize the compile-examples CI workflow's matrix jobs with board type-specific configurations.
This GitHub Actions feature allows defining additional properties for matrix jobs that match the filter:
https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategymatrix
The previous approach for doing this was to use generated environment variable names, which worked but seemed likely to be confusing for anyone trying to decipher the workflow. I think the new approach is a little easier to understand and less hacky.
I had hoped this would allow me to do away with the
board.typesystem, but supplying lists of values to the filter keys isn't supported, you can't reference theenvkey from matrix, and YAML anchors aren't supported by GitHub Actions. So theboard.typesystem remains the only way I can see to avoid redefining the configuration options for each board of the same type.