Fix warnings #302
Merged
Fix warnings #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reorder member initialization on BLELocalCharacteristic - Remove unused variables in: - HCIClass::tryResolveAddress - HCIClass::handleEventPkt (the whole else if statement did nothing) - L2CAPSignalingClass::handleSecurityData (one initialization should be inside of _BLE_TRACE_ - BluetoothCryptoToolbox::f5 - BluetoothCryptoToolbox::testAh - BluetoothCryptoToolbox::testg2 - Uninitialized variable in L2CAPSignalingClass::handleSecurityData
|
|
per1234
added
type: imperfection
|
Friendly ping on this |
|
How can I get this PR reviewed? |
10 tasks
10 tasks
|
@roleroz |
|
Commented on the issue assigned to this, this PR didn't fix all of it, there is one case left. If you can answer the question I put there (#310 (comment)) I'll gladly create another PR for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HCIClass::tryResolveAddressHCIClass::handleEventPkt(the whole else if statement did nothing)L2CAPSignalingClass::handleSecurityData(one initialization should be inside of BLE_TRACEBluetoothCryptoToolbox::f5BluetoothCryptoToolbox::testAhBluetoothCryptoToolbox::testg2L2CAPSignalingClass::handleSecurityDataThere is still a warning in, which I cannot fix without more information (specifically what is the case 0x0A named):