Skip to content

suppress ExperimentalWarning for stream/web on nodejs 16.5+#270

Closed
falkenhawk wants to merge 1 commit intoardatan:masterfrom
falkenhawk:patch-1
Closed

suppress ExperimentalWarning for stream/web on nodejs 16.5+#270
falkenhawk wants to merge 1 commit intoardatan:masterfrom
falkenhawk:patch-1

Conversation

@falkenhawk
Copy link
Copy Markdown

Description

Avoid ExperimentalWarning: stream/web is an experimental feature. This feature could change at any time on nodejs v16.5+

Suppressed warning while stream/web is required, inspired by node-fetch/fetch-blob#125

Related dotansimha/graphql-code-generator#7239 (I did not create an issue on this repo as it is already there on dotansimha/graphql-code-generator)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Ran graphql-codegen after patching this package locally in my node_modules. Warning gone.

Test Environment:

  • OS: win10
  • NodeJS: v16.10.0

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Copy Markdown
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to suppress this warning

@ardatan
Copy link
Copy Markdown
Owner

ardatan commented Jan 17, 2023

I agree with @saihaj . I don't think we should suppress this warning, it should be decided by the user instead. You can use NODE_NO_WARNINGS env var to disable
See dotansimha/graphql-code-generator#7239 (comment)

@ardatan
Copy link
Copy Markdown
Owner

ardatan commented Jan 20, 2023

Closing this for now. We can keep the discussion here.

@ardatan ardatan closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants