suppress ExperimentalWarning for stream/web on nodejs 16.5+#270
Closed
falkenhawk wants to merge 1 commit intoardatan:masterfrom
Closed
suppress ExperimentalWarning for stream/web on nodejs 16.5+#270falkenhawk wants to merge 1 commit intoardatan:masterfrom
falkenhawk wants to merge 1 commit intoardatan:masterfrom
Conversation
saihaj
reviewed
Jan 13, 2023
Collaborator
saihaj
left a comment
There was a problem hiding this comment.
I don't think we need to suppress this warning
Owner
|
I agree with @saihaj . I don't think we should suppress this warning, it should be decided by the user instead. You can use |
Owner
|
Closing this for now. We can keep the discussion here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid
ExperimentalWarning: stream/web is an experimental feature. This feature could change at any timeon nodejs v16.5+Suppressed warning while
stream/webis required, inspired by node-fetch/fetch-blob#125Related dotansimha/graphql-code-generator#7239 (I did not create an issue on this repo as it is already there on
dotansimha/graphql-code-generator)Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Ran graphql-codegen after patching this package locally in my node_modules. Warning gone.
Test Environment:
Checklist:
Further comments