Skip to content

Conversation

theguild-bot
Copy link
Collaborator

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/[email protected]

Patch Changes

@whatwg-node/[email protected]

Patch Changes

  • #2182
    a45e929
    Thanks @ardatan! - - Name functions in iterateAsync for more
    readable traces
    • fakePromise accepts MaybePromise as an input

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from e50def2 to 847c337 Compare March 17, 2025 12:56
Copy link
Contributor

coderabbitai bot commented Mar 17, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Upgraded key dependencies with the Node-fetch package now at v0.7.13 and the Promise-Helpers package at v1.2.5.
    • Improved asynchronous processing efficiency and enhanced support for clearer debugging.

Walkthrough

This pull request removes two changeset documentation files while updating version numbers and changelogs for the @whatwg-node/node-fetch and @whatwg-node/promise-helpers packages. The documentation removal eliminates notes on renaming functions in iterateAsync and on using Array.fromAsync for asynchronous collection. Additionally, version bumps and dependency updates have been applied: node-fetch moves from version 0.7.12 to 0.7.13, and promise-helpers from 1.2.4 to 1.2.5.

Changes

File(s) Change Summary
.changeset/loose-cities-grin.md, .changeset/quiet-corners-tickle.md Deleted changeset files that documented previous patches for @whatwg-node/promise-helpers and @whatwg-node/node-fetch (including naming improvements in iterateAsync and use of Array.fromAsync).
packages/node-fetch/CHANGELOG.md, packages/node-fetch/package.json Updated version to 0.7.13; changelog notes the use of Array.fromAsync for asynchronous value collection and the dependency upgrade of @whatwg-node/promise-helpers to 1.2.5.
packages/promise-helpers/CHANGELOG.md, packages/promise-helpers/package.json Bumped version to 1.2.5; changelog details renaming of functions in iterateAsync for improved trace readability and an update to fakePromise to accept a MaybePromise input.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Caller
    participant NodeFetch as @whatwg-node/node-fetch
    participant ArrayFunc as Array.fromAsync
    Client->>NodeFetch: Initiate fetch operation
    NodeFetch->>ArrayFunc: Gather async values
    ArrayFunc-->>NodeFetch: Return collected values
    NodeFetch-->>Client: Deliver response
Loading
sequenceDiagram
    participant Client as Caller
    participant Iterate as iterateAsync
    participant Fake as fakePromise
    Client->>Iterate: Invoke iterateAsync
    Note right of Iterate: Internal functions renamed for clearer traces
    Client->>Fake: Call fakePromise with MaybePromise input
    Fake-->>Client: Return processed promise
Loading

Possibly related PRs

Poem

I'm a rabbit, hopping through lines of code so fine,
Leaping over changes where new versions now shine.
With functions renamed to dance in clearer trace,
And async collections setting a brisk, smooth pace.
I nibble on updates with a joyful, code-filled heart,
Celebrating improvements with a happy, boundless start! 🐇

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a45e929 and 847c337.

📒 Files selected for processing (6)
  • .changeset/loose-cities-grin.md (0 hunks)
  • .changeset/quiet-corners-tickle.md (0 hunks)
  • packages/node-fetch/CHANGELOG.md (1 hunks)
  • packages/node-fetch/package.json (2 hunks)
  • packages/promise-helpers/CHANGELOG.md (1 hunks)
  • packages/promise-helpers/package.json (1 hunks)
💤 Files with no reviewable changes (2)
  • .changeset/quiet-corners-tickle.md
  • .changeset/loose-cities-grin.md
⏰ Context from checks skipped due to timeout of 90000ms (16)
  • GitHub Check: unit / deno
  • GitHub Check: unit / node 23
  • GitHub Check: unit / node 22
  • GitHub Check: unit / node 20
  • GitHub Check: unit / bun
  • GitHub Check: unit / node 18
  • GitHub Check: server (undici)
  • GitHub Check: type check
  • GitHub Check: e2e / cloudflare-modules
  • GitHub Check: server (ponyfill)
  • GitHub Check: e2e / cloudflare-workers
  • GitHub Check: node-fetch (consumeBody)
  • GitHub Check: e2e / azure-function
  • GitHub Check: server (native)
  • GitHub Check: e2e / aws-lambda
  • GitHub Check: node-fetch (noConsumeBody)
🔇 Additional comments (5)
packages/promise-helpers/package.json (1)

3-3: Version bump is clear and correct.
Updating the version to "1.2.5" aligns with the improvements outlined in the changelog—namely, renaming functions in iterateAsync for enhanced trace readability and enabling fakePromise to accept a MaybePromise as input.

packages/promise-helpers/CHANGELOG.md (1)

3-12: CHANGELOG update for version 1.2.5 is clear and informative.
The new patch notes succinctly document the changes from PR #2182: the renaming of functions within iterateAsync and the modification of fakePromise to accept MaybePromise. This clarity ensures that users can quickly understand what has changed.

packages/node-fetch/CHANGELOG.md (1)

3-15: Accurate update in CHANGELOG for node-fetch 0.7.13.
The patch notes clearly reflect two key changes: the implementation of Array.fromAsync for asynchronous value collection and the dependency update to @whatwg-node/[email protected]. This provides clear traceability and matches the overall upgrade strategy.

packages/node-fetch/package.json (2)

3-3: Version bump update for node-fetch is correct.
Updating the version to "0.7.13" aligns with the release objectives and is consistent with the changes documented in the changelog.


38-38: Dependency update for @whatwg-node/promise-helpers is consistent.
The upgrade from "@whatwg-node/promise-helpers": "^1.0.0" to "@whatwg-node/promise-helpers": "^1.2.5" ensures that node-fetch benefits from the latest enhancements and fixes in the promise-helpers package.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Mar 17, 2025

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=139.869114 min=13      med=139     max=198      p(90)=160     p(95)=165    
     data_received..................: 21 MB  713 kB/s
     data_sent......................: 14 MB  462 kB/s
     http_req_blocked...............: avg=2.8µs      min=651ns   med=1.31µs  max=4.36ms   p(90)=2µs     p(95)=2.24µs 
     http_req_connecting............: avg=923ns      min=0s      med=0s      max=3.11ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.38ms    min=2.16ms  med=20.85ms max=990.13ms p(90)=27.18ms p(95)=28.69ms
       { expected_response:true }...: avg=21.38ms    min=2.16ms  med=20.85ms max=990.13ms p(90)=27.18ms p(95)=28.69ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 139817
     http_req_receiving.............: avg=33.34µs    min=9.35µs  med=22.25µs max=20.02ms  p(90)=36.04µs p(95)=43.16µs
     http_req_sending...............: avg=11.28µs    min=3.46µs  med=6.06µs  max=18.16ms  p(90)=9.33µs  p(95)=13.25µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.34ms    min=2.05ms  med=20.82ms max=990.07ms p(90)=27.14ms p(95)=28.63ms
     http_reqs......................: 139817 4660.076517/s
     iteration_duration.............: avg=42.88ms    min=10.32ms med=41.54ms max=1.01s    p(90)=46.31ms p(95)=52.75ms
     iterations.....................: 69893  2329.521646/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Mar 17, 2025

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 288682      ✗ 0     
     data_received..................: 28 MB   948 kB/s
     data_sent......................: 12 MB   385 kB/s
     http_req_blocked...............: avg=1.44µs   min=902ns   med=1.22µs   max=184.57µs p(90)=1.92µs   p(95)=2.1µs   
     http_req_connecting............: avg=0ns      min=0s      med=0s       max=138.97µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=143.61µs min=96.64µs med=138.47µs max=5.82ms   p(90)=161.04µs p(95)=168.52µs
       { expected_response:true }...: avg=143.61µs min=96.64µs med=138.47µs max=5.82ms   p(90)=161.04µs p(95)=168.52µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 144341
     http_req_receiving.............: avg=25.05µs  min=12.27µs med=23.48µs  max=3.29ms   p(90)=30.91µs  p(95)=33.7µs  
     http_req_sending...............: avg=6.56µs   min=4.07µs  med=5.79µs   max=231.44µs p(90)=8.34µs   p(95)=9.37µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=111.98µs min=71.89µs med=106.58µs max=5.74ms   p(90)=125.91µs p(95)=132.12µs
     http_reqs......................: 144341  4811.173546/s
     iteration_duration.............: avg=203.29µs min=142µs   med=197.59µs max=6.21ms   p(90)=223.49µs p(95)=233.1µs 
     iterations.....................: 144341  4811.173546/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Mar 17, 2025

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 235176      ✗ 0     
     data_received..................: 24 MB   788 kB/s
     data_sent......................: 9.4 MB  314 kB/s
     http_req_blocked...............: avg=1.38µs   min=891ns    med=1.16µs   max=274.42µs p(90)=1.86µs   p(95)=2.02µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=121.11µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=193.92µs min=141.7µs  med=184.1µs  max=11.98ms  p(90)=209.42µs p(95)=218.67µs
       { expected_response:true }...: avg=193.92µs min=141.7µs  med=184.1µs  max=11.98ms  p(90)=209.42µs p(95)=218.67µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 117588
     http_req_receiving.............: avg=24.84µs  min=13.15µs  med=23.19µs  max=2.56ms   p(90)=30.12µs  p(95)=32.81µs 
     http_req_sending...............: avg=6.16µs   min=4.02µs   med=5.28µs   max=2.54ms   p(90)=8µs      p(95)=8.55µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=162.91µs min=118.2µs  med=152.87µs max=9.38ms   p(90)=175.38µs p(95)=183.97µs
     http_reqs......................: 117588  3919.466582/s
     iteration_duration.............: avg=250.73µs min=184.27µs med=239.92µs max=14.92ms  p(90)=268.35µs p(95)=280.06µs
     iterations.....................: 117588  3919.466582/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Mar 17, 2025

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 211112      ✗ 0     
     data_received..................: 21 MB   707 kB/s
     data_sent......................: 8.4 MB  282 kB/s
     http_req_blocked...............: avg=1.49µs   min=902ns    med=1.28µs   max=322.84µs p(90)=1.94µs   p(95)=2.14µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=143.56µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=217.25µs min=157.97µs med=203.47µs max=80.34ms  p(90)=229.45µs p(95)=239.62µs
       { expected_response:true }...: avg=217.25µs min=157.97µs med=203.47µs max=80.34ms  p(90)=229.45µs p(95)=239.62µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 105556
     http_req_receiving.............: avg=26.12µs  min=13.83µs  med=24.11µs  max=3.08ms   p(90)=31.44µs  p(95)=34.15µs 
     http_req_sending...............: avg=6.96µs   min=4.11µs   med=6.55µs   max=358.72µs p(90)=8.6µs    p(95)=9.79µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=184.17µs min=131.92µs med=170.74µs max=80.24ms  p(90)=193.78µs p(95)=203.12µs
     http_reqs......................: 105556  3518.373008/s
     iteration_duration.............: avg=279.37µs min=201.87µs med=264.55µs max=80.52ms  p(90)=294.12µs p(95)=306.5µs 
     iterations.....................: 105556  3518.373008/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Mar 17, 2025

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.612052 min=13     med=141     max=181     p(90)=161     p(95)=166    
     data_received..................: 20 MB  668 kB/s
     data_sent......................: 13 MB  428 kB/s
     http_req_blocked...............: avg=2.21µs     min=661ns  med=1.23µs  max=4.34ms  p(90)=2.04µs  p(95)=2.33µs 
     http_req_connecting............: avg=310ns      min=0s     med=0s      max=3.11ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.84ms    min=2.38ms med=22.2ms  max=1.07s   p(90)=28.53ms p(95)=30.44ms
       { expected_response:true }...: avg=22.84ms    min=2.38ms med=22.2ms  max=1.07s   p(90)=28.53ms p(95)=30.44ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 130901
     http_req_receiving.............: avg=34.55µs    min=9.34µs med=23.79µs max=17.35ms p(90)=38.07µs p(95)=44.91µs
     http_req_sending...............: avg=10.57µs    min=3.36µs med=5.96µs  max=6.03ms  p(90)=9.88µs  p(95)=13.8µs 
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.8ms     min=2.22ms med=22.16ms max=1.07s   p(90)=28.49ms p(95)=30.38ms
     http_reqs......................: 130901 4363.005606/s
     iteration_duration.............: avg=45.8ms     min=9.7ms  med=44.09ms max=1.09s   p(90)=50.27ms p(95)=56.07ms
     iterations.....................: 65434  2180.952848/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@ardatan ardatan merged commit c654f0a into master Mar 17, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants