Skip to content

Conversation

@theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Feb 25, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/[email protected]

Minor Changes

Summary by CodeRabbit

  • New Features
    • Introduced a new asynchronous iteration capability to streamline operations.
  • Documentation
    • Refreshed release notes to accurately reflect the enhancements.
  • Chores
    • Updated the package version to mark a new minor release.

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 4190dbd to 9816bdd Compare February 25, 2025 18:58
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2025

Walkthrough

This pull request removes the changeset file that documented the minor version update and the addition of the iterateAsync function from the package @whatwg-node/promise-helpers. Additionally, the changelog has been updated with a new version entry (1.1.0) detailing the addition of iterateAsync, and the package's version in package.json was updated from 1.0.0 to 1.1.0.

Changes

File(s) Change Summary
.changeset/fruity-readers-jump.md Deleted file that previously documented a minor version update and the addition of the iterateAsync function.
packages/promise-helpers/CHANGELOG.md Added a new entry for version 1.1.0, including a Minor Changes section and documentation for the iterateAsync function (commit fae5127, contrib. @ardatan).
packages/promise-helpers/package.json Updated the package version from "1.0.0" to "1.1.0".

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant P as Promise Helpers
    U->>P: Call iterateAsync(iterable, processItem)
    P-->>U: Returns async iterator
    loop Asynchronously process items
        U->>P: Process item
    end
Loading

Possibly related PRs

  • Upcoming Release Changes #2104: Involves similar updates to the @whatwg-node/promise-helpers package by documenting new promise helpers, including the introduction of the iterateAsync function.

Poem

I'm a rabbit on a coding spree,
Hopping into functions with glee.
iterateAsync makes loops a delight,
Version bumps shine so bright.
Code carrots crunch as bugs flee,
A whimsical update from me to thee!
🥕🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9816bdd and af5e6f8.

📒 Files selected for processing (3)
  • .changeset/fruity-readers-jump.md (0 hunks)
  • packages/promise-helpers/CHANGELOG.md (1 hunks)
  • packages/promise-helpers/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/fruity-readers-jump.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/promise-helpers/package.json
  • packages/promise-helpers/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (17)
  • GitHub Check: unit / deno
  • GitHub Check: unit / node 23
  • GitHub Check: unit / node 22
  • GitHub Check: unit / node 20
  • GitHub Check: unit / node 18
  • GitHub Check: server (undici)
  • GitHub Check: unit / bun
  • GitHub Check: release-candidate / snapshot
  • GitHub Check: server (ponyfill)
  • GitHub Check: type check
  • GitHub Check: prettier
  • GitHub Check: server (native)
  • GitHub Check: node-fetch (consumeBody)
  • GitHub Check: esm
  • GitHub Check: node-fetch (noConsumeBody)
  • GitHub Check: lint
  • GitHub Check: Analyze (javascript-typescript)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/promise-helpers 1.1.0-rc-20250225190237-af5e6f8bafa69686547fe88087092f80196205e8 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.831179 min=32      med=142     max=180     p(90)=161     p(95)=166    
     data_received..................: 20 MB  680 kB/s
     data_sent......................: 13 MB  436 kB/s
     http_req_blocked...............: avg=3.59µs     min=621ns   med=1.33µs  max=5.63ms  p(90)=2.08µs  p(95)=2.36µs 
     http_req_connecting............: avg=1.71µs     min=0s      med=0s      max=5.6ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.43ms    min=6.13ms  med=21.8ms  max=1.16s   p(90)=28.03ms p(95)=29.76ms
       { expected_response:true }...: avg=22.43ms    min=6.13ms  med=21.8ms  max=1.16s   p(90)=28.03ms p(95)=29.76ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 133280
     http_req_receiving.............: avg=34.71µs    min=9.17µs  med=23.85µs max=22.88ms p(90)=37.75µs p(95)=44.43µs
     http_req_sending...............: avg=11.37µs    min=3.23µs  med=6.15µs  max=29.43ms p(90)=9.83µs  p(95)=13.77µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.39ms    min=6.09ms  med=21.77ms max=1.16s   p(90)=27.99ms p(95)=29.69ms
     http_reqs......................: 133280 4442.021408/s
     iteration_duration.............: avg=44.98ms    min=20.52ms med=43.32ms max=1.19s   p(90)=48.61ms p(95)=55.21ms
     iterations.....................: 66609  2219.977521/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.559904 min=36      med=141     max=189     p(90)=159     p(95)=163    
     data_received..................: 20 MB  674 kB/s
     data_sent......................: 13 MB  437 kB/s
     http_req_blocked...............: avg=4.9µs      min=651ns   med=1.32µs  max=13.4ms  p(90)=2.05µs  p(95)=2.36µs 
     http_req_connecting............: avg=3.02µs     min=0s      med=0s      max=10.42ms p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.61ms    min=6.41ms  med=21.97ms max=1.16s   p(90)=28.51ms p(95)=30.24ms
       { expected_response:true }...: avg=22.61ms    min=6.41ms  med=21.97ms max=1.16s   p(90)=28.51ms p(95)=30.24ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 132235
     http_req_receiving.............: avg=34.35µs    min=9.53µs  med=24.38µs max=7.08ms  p(90)=39.21µs p(95)=46.16µs
     http_req_sending...............: avg=12.56µs    min=3.38µs  med=6.51µs  max=12.38ms p(90)=10.16µs p(95)=14.84µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.56ms    min=6.36ms  med=21.94ms max=1.15s   p(90)=28.47ms p(95)=30.18ms
     http_reqs......................: 132235 4407.366816/s
     iteration_duration.............: avg=45.34ms    min=19.46ms med=43.7ms  max=1.18s   p(90)=49.41ms p(95)=55.14ms
     iterations.....................: 66097  2203.000147/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 9816bdd to af5e6f8 Compare February 25, 2025 19:00
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 300046      ✗ 0     
     data_received..................: 30 MB   985 kB/s
     data_sent......................: 12 MB   400 kB/s
     http_req_blocked...............: avg=1.34µs   min=851ns    med=1.15µs   max=179.59µs p(90)=1.83µs   p(95)=1.98µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=114.72µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=138.06µs min=94.83µs  med=133.55µs max=5.72ms   p(90)=155.94µs p(95)=162.68µs
       { expected_response:true }...: avg=138.06µs min=94.83µs  med=133.55µs max=5.72ms   p(90)=155.94µs p(95)=162.68µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 150023
     http_req_receiving.............: avg=24.02µs  min=12.06µs  med=22.51µs  max=2.91ms   p(90)=29.98µs  p(95)=32.51µs 
     http_req_sending...............: avg=6.21µs   min=4µs      med=5.34µs   max=1ms      p(90)=8.01µs   p(95)=8.55µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=107.82µs min=67.23µs  med=103.08µs max=5.56ms   p(90)=122µs    p(95)=127.45µs
     http_reqs......................: 150023  5000.607534/s
     iteration_duration.............: avg=195.51µs min=140.86µs med=190.24µs max=5.89ms   p(90)=215.7µs  p(95)=224.49µs
     iterations.....................: 150023  5000.607534/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 216226      ✗ 0     
     data_received..................: 22 MB   724 kB/s
     data_sent......................: 8.6 MB  288 kB/s
     http_req_blocked...............: avg=1.43µs   min=862ns    med=1.2µs    max=196.06µs p(90)=1.95µs   p(95)=2.12µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=121.38µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=214.36µs min=159.55µs med=201.82µs max=58.1ms   p(90)=228.95µs p(95)=239.35µs
       { expected_response:true }...: avg=214.36µs min=159.55µs med=201.82µs max=58.1ms   p(90)=228.95µs p(95)=239.35µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 108113
     http_req_receiving.............: avg=25.55µs  min=13.82µs  med=23.72µs  max=3.21ms   p(90)=30.87µs  p(95)=33.55µs 
     http_req_sending...............: avg=6.48µs   min=4.2µs    med=5.65µs   max=432.02µs p(90)=8.25µs   p(95)=8.98µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=182.32µs min=132.11µs med=170.16µs max=58.03ms  p(90)=193.71µs p(95)=202.87µs
     http_reqs......................: 108113  3603.430144/s
     iteration_duration.............: avg=272.95µs min=202.87µs med=259.29µs max=58.25ms  p(90)=290.45µs p(95)=303.51µs
     iterations.....................: 108113  3603.430144/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 232016      ✗ 0     
     data_received..................: 23 MB   777 kB/s
     data_sent......................: 9.3 MB  309 kB/s
     http_req_blocked...............: avg=1.37µs   min=862ns    med=1.15µs   max=1.14ms   p(90)=1.82µs   p(95)=1.98µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=137.42µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=196.38µs min=143.33µs med=186.09µs max=7.31ms   p(90)=212.89µs p(95)=222.38µs
       { expected_response:true }...: avg=196.38µs min=143.33µs med=186.09µs max=7.31ms   p(90)=212.89µs p(95)=222.38µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 116008
     http_req_receiving.............: avg=24.98µs  min=13.46µs  med=23.23µs  max=2.61ms   p(90)=30.55µs  p(95)=33.4µs  
     http_req_sending...............: avg=6.26µs   min=4.06µs   med=5.39µs   max=276.98µs p(90)=8.05µs   p(95)=8.71µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=165.13µs min=122.87µs med=154.52µs max=7.27ms   p(90)=177.9µs  p(95)=187.03µs
     http_reqs......................: 116008  3866.793151/s
     iteration_duration.............: avg=254.22µs min=186.4µs  med=242.99µs max=7.41ms   p(90)=273.05µs p(95)=285.43µs
     iterations.....................: 116008  3866.793151/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit ec70df9 into master Feb 25, 2025
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants