Skip to content

Conversation

@theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Feb 24, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/[email protected]

Patch Changes

  • #2093
    31f021a
    Thanks @ardatan! - Fixes the
    TypeError: bodyInit.stream is not a function error thrown when @whatwg-node/server is used
    with node:http2 and attempts the incoming HTTP/2 request to parse with Request.json,
    Request.text, Request.formData, or Request.blob methods.

  • Updated dependencies
    [31f021a]:

@whatwg-node/[email protected]

Patch Changes

  • #2093
    31f021a
    Thanks @ardatan! - Fixes the
    TypeError: bodyInit.stream is not a function error thrown when @whatwg-node/server is used
    with node:http2 and attempts the incoming HTTP/2 request to parse with Request.json,
    Request.text, Request.formData, or Request.blob methods.

@whatwg-node/[email protected]

Patch Changes

  • #2093
    31f021a
    Thanks @ardatan! - Fixes the
    TypeError: bodyInit.stream is not a function error thrown when @whatwg-node/server is used
    with node:http2 and attempts the incoming HTTP/2 request to parse with Request.json,
    Request.text, Request.formData, or Request.blob methods.

  • Updated dependencies
    [31f021a]:

@benchmarks/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue that could disrupt processing of certain network requests, leading to smoother operations in modern HTTP scenarios.
  • Chores

    • Upgraded several package versions and updated key dependencies across modules, ensuring improved stability, enhanced compatibility, and overall performance refinements.

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 0b4738c to 56cbafa Compare February 24, 2025 10:26
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2025

Walkthrough

This pull request removes a patch changeset that addressed a TypeError when using HTTP/2 with the @whatwg-node packages. In addition, it bumps version numbers and updates dependency versions across multiple packages including benchmarks/server, e2e/aws-lambda, e2e/shared-server, e2e/vercel, packages/fetch, packages/node-fetch, and packages/server. The changes focus on fixing HTTP/2 request parsing errors (affecting methods like Request.json, Request.text, Request.formData, and Request.blob) without modifying the public API.

Changes

File(s) Change Summary
.changeset/mighty-worlds-smoke.md Deleted file containing a patch for HTTP/2 TypeError issues in @whatwg-node/node-fetch, @whatwg-node/server, and @whatwg-node/fetch.
benchmarks/server/{CHANGELOG.md, package.json} Added version 0.0.44 entry with dependency update for @whatwg-node/server (0.9.68 → 0.9.69) and bumped the package version.
e2e/aws-lambda/{CHANGELOG.md, package.json} Bumped version from 0.0.38 to 0.0.39 and updated @whatwg-node/fetch from 0.10.4 to 0.10.5.
e2e/shared-server/{CHANGELOG.md, package.json} Bumped version from 0.0.131 to 0.0.132 and updated dependencies: @whatwg-node/server (0.9.68 → 0.9.69) and @whatwg-node/fetch (0.10.4 → 0.10.5).
e2e/vercel/{CHANGELOG.md, package.json} Bumped version from 0.0.131 to 0.0.132 and updated dependency @e2e/shared-server from 0.0.131 to 0.0.132.
packages/fetch/{CHANGELOG.md, package.json} Bumped version from 0.10.4 to 0.10.5; updated @whatwg-node/node-fetch from ^0.7.10 to ^0.7.11; fixed HTTP/2 parsing error.
packages/node-fetch/{CHANGELOG.md, package.json} Bumped version from 0.7.10 to 0.7.11 with changelog detailing the HTTP/2 TypeError fix.
packages/server/{CHANGELOG.md, package.json} Bumped version from 0.9.68 to 0.9.69; updated @whatwg-node/fetch from ^0.10.4 to ^0.10.5 with changelog describing the HTTP/2 TypeError fix.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant HTTP2Module as HTTP/2 Module
    participant Server as @whatwg-node/server
    participant Fetch as @whatwg-node/fetch

    Client->>HTTP2Module: Send HTTP/2 Request
    HTTP2Module->>Server: Forward Request
    Server->>Fetch: Process request with Request.json/text/formData/blob
    Fetch-->>Server: Return parsed body (patched)
    Server-->>HTTP2Module: Send response
    HTTP2Module-->>Client: Deliver response
Loading

Possibly related PRs

Suggested reviewers

  • dotansimha

Poem

I hop through bundles of code so light,
Banishing errors from morning to night.
HTTP/2 flows smooth and free,
With patches fixing streams with glee.
My bunny paws rejoice in each fix tight –
A joyful hop in the digital byte! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31f021a and 56cbafa.

📒 Files selected for processing (15)
  • .changeset/mighty-worlds-smoke.md (0 hunks)
  • benchmarks/server/CHANGELOG.md (1 hunks)
  • benchmarks/server/package.json (2 hunks)
  • e2e/aws-lambda/CHANGELOG.md (1 hunks)
  • e2e/aws-lambda/package.json (1 hunks)
  • e2e/shared-server/CHANGELOG.md (1 hunks)
  • e2e/shared-server/package.json (1 hunks)
  • e2e/vercel/CHANGELOG.md (1 hunks)
  • e2e/vercel/package.json (2 hunks)
  • packages/fetch/CHANGELOG.md (1 hunks)
  • packages/fetch/package.json (2 hunks)
  • packages/node-fetch/CHANGELOG.md (1 hunks)
  • packages/node-fetch/package.json (1 hunks)
  • packages/server/CHANGELOG.md (1 hunks)
  • packages/server/package.json (2 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/mighty-worlds-smoke.md
✅ Files skipped from review due to trivial changes (10)
  • packages/server/package.json
  • benchmarks/server/CHANGELOG.md
  • packages/node-fetch/package.json
  • e2e/aws-lambda/CHANGELOG.md
  • e2e/vercel/package.json
  • e2e/aws-lambda/package.json
  • benchmarks/server/package.json
  • e2e/shared-server/CHANGELOG.md
  • e2e/shared-server/package.json
  • e2e/vercel/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (15)
  • GitHub Check: unit / node 23
  • GitHub Check: unit / node 22
  • GitHub Check: unit / deno
  • GitHub Check: unit / bun
  • GitHub Check: unit / node 20
  • GitHub Check: release-candidate / snapshot
  • GitHub Check: unit / node 18
  • GitHub Check: server (undici)
  • GitHub Check: e2e / cloudflare-modules
  • GitHub Check: server (ponyfill)
  • GitHub Check: e2e / cloudflare-workers
  • GitHub Check: node-fetch (consumeBody)
  • GitHub Check: e2e / azure-function
  • GitHub Check: server (native)
  • GitHub Check: e2e / aws-lambda
🔇 Additional comments (6)
packages/fetch/package.json (2)

3-3: Version Bump to 0.10.5
The package version has been correctly updated to "0.10.5" to reflect the minor release with the HTTP/2 parsing fix.


18-19: Dependency Update: @whatwg-node/node-fetch
The dependency on @whatwg-node/node-fetch is updated to "^0.7.11", which aligns with the fix for the TypeError issue. This update ensures compatibility across the packages.

packages/node-fetch/CHANGELOG.md (1)

3-13: Changelog Entry for Version 0.7.11
The changelog for version 0.7.11 is clear and detailed. It explains that the patch fixes the TypeError: bodyInit.stream is not a function error when using the server with HTTP/2, and it properly references PR [#2093].

packages/server/CHANGELOG.md (2)

3-13: Changelog Entry for Version 0.9.69
The new version entry for 0.9.69 is comprehensive. It documents the patch that addresses the HTTP/2 parsing error by fixing the bodyInit.stream issue and credits the relevant PR. This clarity helps maintainers understand the fix in context.


14-17: Dependency Update in Server Changelog
The dependency update to use @whatwg-node/[email protected] is explicitly noted, ensuring that inter-package dependency requirements are met for the fix.

packages/fetch/CHANGELOG.md (1)

3-17: Changelog Entry for Version 0.10.5
The changelog entry for 0.10.5 is well written. It details the fix for the TypeError: bodyInit.stream is not a function issue by referencing the appropriate PR, and it documents the updated dependency on @whatwg-node/node-fetch (now at "^0.7.11"). This clear documentation assures consistency with the changes in related packages.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.69371 min=19      med=140     max=184     p(90)=161     p(95)=165    
     data_received..................: 21 MB  708 kB/s
     data_sent......................: 14 MB  459 kB/s
     http_req_blocked...............: avg=3.29µs    min=651ns   med=1.35µs  max=8.91ms  p(90)=2.02µs  p(95)=2.31µs 
     http_req_connecting............: avg=1.21µs    min=0s      med=0s      max=4.66ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.52ms   min=4.64ms  med=20.89ms max=1.17s   p(90)=27.09ms p(95)=28.74ms
       { expected_response:true }...: avg=21.52ms   min=4.64ms  med=20.89ms max=1.17s   p(90)=27.09ms p(95)=28.74ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 138935
     http_req_receiving.............: avg=32.42µs   min=9.16µs  med=22.1µs  max=12.66ms p(90)=36.38µs p(95)=43.32µs
     http_req_sending...............: avg=10.75µs   min=3.36µs  med=5.99µs  max=4.15ms  p(90)=9.52µs  p(95)=13.5µs 
     http_req_tls_handshaking.......: avg=0s        min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.48ms   min=4.6ms   med=20.85ms max=1.17s   p(90)=27.05ms p(95)=28.69ms
     http_reqs......................: 138935 4630.609074/s
     iteration_duration.............: avg=43.16ms   min=15.95ms med=41.53ms max=1.2s    p(90)=46.82ms p(95)=52.78ms
     iterations.....................: 69444  2314.521298/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@github-actions
Copy link
Contributor

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.875535 min=51      med=141     max=183     p(90)=160     p(95)=165    
     data_received..................: 20 MB  656 kB/s
     data_sent......................: 13 MB  420 kB/s
     http_req_blocked...............: avg=3.79µs     min=642ns   med=1.35µs  max=9.85ms  p(90)=2.06µs  p(95)=2.39µs 
     http_req_connecting............: avg=1.87µs     min=0s      med=0s      max=5.49ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=23.26ms    min=6.8ms   med=22.58ms max=1.06s   p(90)=29.22ms p(95)=31.17ms
       { expected_response:true }...: avg=23.26ms    min=6.8ms   med=22.58ms max=1.06s   p(90)=29.22ms p(95)=31.17ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 128557
     http_req_receiving.............: avg=34.93µs    min=10.02µs med=25.38µs max=11.32ms p(90)=39.55µs p(95)=46.01µs
     http_req_sending...............: avg=11.96µs    min=3.5µs   med=6.6µs   max=16.03ms p(90)=10.39µs p(95)=14.15µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=23.21ms    min=6.77ms  med=22.54ms max=1.06s   p(90)=29.18ms p(95)=31.11ms
     http_reqs......................: 128557 4284.395265/s
     iteration_duration.............: avg=46.63ms    min=20.91ms med=44.79ms max=1.08s   p(90)=52.2ms  p(95)=57.78ms
     iterations.....................: 64259  2141.54776/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

@github-actions
Copy link
Contributor

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 216090      ✗ 0     
     data_received..................: 22 MB   724 kB/s
     data_sent......................: 8.6 MB  288 kB/s
     http_req_blocked...............: avg=1.45µs   min=922ns    med=1.24µs   max=254.4µs  p(90)=1.92µs   p(95)=2.09µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=132.69µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=213.76µs min=156.33µs med=202.29µs max=47.15ms  p(90)=227.31µs p(95)=236.34µs
       { expected_response:true }...: avg=213.76µs min=156.33µs med=202.29µs max=47.15ms  p(90)=227.31µs p(95)=236.34µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 108045
     http_req_receiving.............: avg=26.03µs  min=13.4µs   med=24.31µs  max=2.8ms    p(90)=31.37µs  p(95)=33.9µs  
     http_req_sending...............: avg=6.52µs   min=4.1µs    med=5.79µs   max=287.95µs p(90)=8.21µs   p(95)=9.01µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=181.2µs  min=130.28µs med=170.29µs max=47.05ms  p(90)=192.12µs p(95)=200.48µs
     http_reqs......................: 108045  3601.376615/s
     iteration_duration.............: avg=272.98µs min=200.98µs med=260.58µs max=47.3ms   p(90)=289.23µs p(95)=300.3µs 
     iterations.....................: 108045  3601.376615/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 229894      ✗ 0     
     data_received..................: 23 MB   770 kB/s
     data_sent......................: 9.2 MB  307 kB/s
     http_req_blocked...............: avg=1.41µs   min=892ns    med=1.2µs    max=204.44µs p(90)=1.88µs   p(95)=2.04µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=140.38µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=197.7µs  min=142.41µs med=188.21µs max=7.34ms   p(90)=213.34µs p(95)=222.7µs 
       { expected_response:true }...: avg=197.7µs  min=142.41µs med=188.21µs max=7.34ms   p(90)=213.34µs p(95)=222.7µs 
     http_req_failed................: 0.00%   ✓ 0           ✗ 114947
     http_req_receiving.............: avg=25.78µs  min=13.29µs  med=24.19µs  max=2.67ms   p(90)=31.37µs  p(95)=34.04µs 
     http_req_sending...............: avg=6.45µs   min=4.07µs   med=5.67µs   max=249.62µs p(90)=8.18µs   p(95)=8.96µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=165.45µs min=113.98µs med=156.14µs max=7.31ms   p(90)=178.42µs p(95)=187.14µs
     http_reqs......................: 114947  3831.428815/s
     iteration_duration.............: avg=256.43µs min=184.9µs  med=246.02µs max=7.41ms   p(90)=274.65µs p(95)=286.52µs
     iterations.....................: 114947  3831.428815/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@github-actions
Copy link
Contributor

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/fetch 0.10.5-rc-20250224102947-56cbafa57aa3a2d5c97ffcd44f35cb98d37c47a3 npm ↗︎ unpkg ↗︎
@whatwg-node/node-fetch 0.7.11-rc-20250224102947-56cbafa57aa3a2d5c97ffcd44f35cb98d37c47a3 npm ↗︎ unpkg ↗︎
@whatwg-node/server 0.9.69-rc-20250224102947-56cbafa57aa3a2d5c97ffcd44f35cb98d37c47a3 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 290166      ✗ 0     
     data_received..................: 29 MB   953 kB/s
     data_sent......................: 12 MB   387 kB/s
     http_req_blocked...............: avg=1.42µs   min=892ns    med=1.21µs   max=184.57µs p(90)=1.89µs   p(95)=2.06µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=125.65µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=142.14µs min=95.97µs  med=137.22µs max=5.98ms   p(90)=159.01µs p(95)=165.95µs
       { expected_response:true }...: avg=142.14µs min=95.97µs  med=137.22µs max=5.98ms   p(90)=159.01µs p(95)=165.95µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 145083
     http_req_receiving.............: avg=24.71µs  min=11.93µs  med=23.22µs  max=2.9ms    p(90)=30.61µs  p(95)=33.28µs 
     http_req_sending...............: avg=6.61µs   min=4.19µs   med=5.87µs   max=292.16µs p(90)=8.34µs   p(95)=9.31µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=110.81µs min=67.9µs   med=105.47µs max=5.93ms   p(90)=124.36µs p(95)=130.1µs 
     http_reqs......................: 145083  4835.888113/s
     iteration_duration.............: avg=202.14µs min=142.35µs med=196.6µs  max=6.61ms   p(90)=221.26µs p(95)=230.29µs
     iterations.....................: 145083  4835.888113/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit 1bd2f8f into master Feb 24, 2025
25 checks passed
This was referenced Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants