Update and improve the builder infrastructure. #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
reviewed
Feb 27, 2025
| this ISpecificationBuilder<T> builder, | ||
| bool condition) where T : class | ||
| { | ||
| if (condition) |
There was a problem hiding this comment.
What's the purpose of passing in a condition flag?
There was a problem hiding this comment.
It's similar to WhereIf types of LINQ extensions. In our case, if the condition is false, the statement does nothing, meaning the expression/value is not added to the specification state. This allows you to have a more succinct way of expressing the query. Instead of having if clauses, you can pass that condition to the extension method itself. We have this for a long time.
The #420 contains more details
ardalis
approved these changes
Feb 27, 2025
This was referenced Jul 21, 2025
Closed
Closed
This was referenced Jul 29, 2025
This was referenced Oct 1, 2025
This was referenced Oct 9, 2025
Bump Ardalis.Specification.EntityFrameworkCore from 7.0.0 to 9.3.1
mohamed-aadhil/eShopOnWeb_Clone#4
Open
Open
This was referenced Oct 16, 2025
This was referenced Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #419
Fixes #420