Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create headers package #224

Closed
blaine-arcjet opened this issue Feb 12, 2024 · 0 comments · Fixed by #824
Closed

Create headers package #224

blaine-arcjet opened this issue Feb 12, 2024 · 0 comments · Fixed by #824
Assignees
@blaine-arcjet

Comments

@blaine-arcjet
Copy link
Contributor

We currently expose ArcjetHeaders from the core SDK, but we should make it a separate package.
@blaine-arcjet blaine-arcjet self-assigned this Feb 12, 2024
@blaine-arcjet blaine-arcjet mentioned this issue May 24, 2024
Merged
@trunk-io trunk-io bot closed this as completed in #824 May 28, 2024
trunk-io bot pushed a commit that referenced this issue May 28, 2024
@blaine-arcjet
feat!: Separate @arcjet/headers package from core (#824)
c8364f4 
Closes #224 

This separates the `ArcjetHeaders` package into its own package. This means it is no longer exported from `arcjet` and anyone consuming it will need to depend on `@arcjet/headers` directly.

Separating it out gave me a chance to think through unnatural usage in non-TypeScript environments so I added tests and guards around those situations. Having this package separate will allow us to improve/fix it independent of arcjet core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blaine-arcjet blaine-arcjet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Separate @arcjet/headers package from core arcjet/arcjet-js
1 participant
@blaine-arcjet