Skip to content

Commit

Permalink
fix(protocol)!: Export only things we use from connect and buf (#783)
Browse files Browse the repository at this point in the history
While working on #775, I found that Vite breaks when we try to bundle `@arcjet/protocol` because these buf and connect dependencies export overlapping identifiers and it doesn't know how to detect the correct one. 

Instead, I slimmed these exports to things that we use. I think I found everything between the various projects but marking this as breaking in case others were being used.
  • Loading branch information
blaine-arcjet authored May 20, 2024
1 parent 8b5c648 commit 4596da5
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions protocol/proto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,9 @@
export * from "./gen/es/decide/v1alpha1/decide_pb.js";
export * from "./gen/es/decide/v1alpha1/decide_connect.js";

export * from "@bufbuild/protobuf";
export * from "@connectrpc/connect";
export { Timestamp, proto3 } from "@bufbuild/protobuf";
export {
createPromiseClient,
createRouterTransport,
type Transport,
} from "@connectrpc/connect";

0 comments on commit 4596da5

Please sign in to comment.