-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce DisplayType component that outputs pretty-printed types #306
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/[email protected] |
|
Nice! Any reason why you didn't also do rate limiting, bot detection, and signup form protection? |
Yes, the reason was stated as
I see that I wasn't explicit that those changes would need to be done to effectively use this component on types for those rules. |
This introduces an Astro component that loads a module, extracts a specified type, simplifies it by one level, and then pretty-prints it.
This will ensure that our docs always match exported types from the SDK packages and can reduce the work needed to document large types like
NoseconeOptions
.It doesn't work on all types because we might want to handwrite them in a simpler fashion, such as the
SensitiveInfoOptions
; this is common when we have heavy use of generics.This work also highlighted some places where we should probably export types, such as
BotOptionsAllow
andBotOptionsDeny
.TypeScript has a hardcoded truncation length. It is on their roadmap, but in the meantime I introduced
patch-package
to update the value when we donpm ci
.Lastly, I cleaned up some of the wording in the reference documentation where I introduced
<DisplayType />