chore: cosmos-sdk bump to v0.50 #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spoorthi <[email protected]>
spoo-bar
requested review from
philabsbot,
fdymylja,
aelesbao and
zanicar
and removed request for
a team
zanicar
reviewed
Jun 20, 2024
| valSet: validatorSet, | ||
| valSigners: valSigners, | ||
| accPrivKeys: genAccPrivKeys, | ||
| } | ||
| chain.BeginBlock() |
There was a problem hiding this comment.
What is happening between lines 263-281;
Copypasta?
There was a problem hiding this comment.
this will need to be handled when the tests are further fixed. Didnt want to lose the original code by removing it.
zanicar
approved these changes
Jun 20, 2024
fdymylja
approved these changes
Jun 21, 2024
aelesbao
reviewed
Jun 21, 2024
Comment on lines
+1
to
+28
| package gov | ||
|
|
||
| import ( | ||
| "cosmossdk.io/collections" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| govkeeper "github.com/cosmos/cosmos-sdk/x/gov/keeper" | ||
| govtypes "github.com/cosmos/cosmos-sdk/x/gov/types/v1" | ||
| ) | ||
|
|
||
| type Keeper struct { | ||
| govKeeper govkeeper.Keeper | ||
| } | ||
|
|
||
| // NewKeeper creates a new Keeper instance. | ||
| func NewKeeper(govkeeper govkeeper.Keeper) Keeper { | ||
| return Keeper{ | ||
| govKeeper: govkeeper, | ||
| } | ||
| } | ||
|
|
||
| // GetVote returns the vote of a voter on a proposal. | ||
| func (k Keeper) GetVote(ctx sdk.Context, proposalID uint64, voterAddr sdk.AccAddress) (govtypes.Vote, bool) { | ||
| vote, err := k.govKeeper.Votes.Get(ctx, collections.Join(proposalID, voterAddr)) | ||
| if err != nil { | ||
| return govtypes.Vote{}, false | ||
| } | ||
| return vote, true | ||
| } |
There was a problem hiding this comment.
I imagine this had to be kept just because of our custom WASM Binding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the following on Archway
v0.45.0-archway=>v0.50.0-archwayv7.4.0=>v8.2.1v0.47.11=>v0.50.6Additionally, at the protocol level it does the following
option (cosmos.msg.v1.service) = true;Misc changes
v1.5.5as thelatestis not currently stable.