extra/rust: Add fix for Apple M1 #1925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Picht <[email protected]>
mipimipi
referenced
this pull request
in AsahiLinux/alarm-PKGBUILDs
Jun 9, 2022
jemalloc is broken by default on architectures like aarch64, where the page size is not a constant (it requires compile-time page size >= run-time page size). Force it to build for 64K pages, which should work for all possible ARM systems.
|
Hello! This is a current problem that people are encountering in the wild at rapidly increasing frequencies, as it seems Asahi + Arch is a strongly preferred combination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Apple M1, the rust package does not build.
This PR sets the page size for jemalloc to 16K (as originally suggested by @marcan). With that fix, the rust package can be built and used on Apple M1. Apart from Apple M1, I tested the fix for "standard" aarch64 and for armv7h successfully.