Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin not applying plugins as intended #29

Open
wants to merge 1 commit into
base: 3.4
Choose a base branch
from

Conversation

ENDERZOMBI102
Copy link

when the architectury plugin is applied, it tries to apply 4 more plugins ( java, eclipse, idea and org.jetbrains.gradle.plugin.idea-ext ), but the way it was done caused only the last one ( org.jetbrains.gradle.plugin.idea-ext ) to actually apply, as maps cannot contain more than one value for a specific key, this PR fixes this by using the project.pluginManager.apply() method to apply each plugin individually.

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2023

CLA assistant check
All committers have signed the CLA.

@ENDERZOMBI102 ENDERZOMBI102 changed the title actually make plugins apply Fix plugin not applying plugins as intended Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants