Specify the database name when connecting #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jahangiranwari
added a commit
to jahangiranwari/pgloader
that referenced
this pull request
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specifies the name of the database to connect to upon login.
This is required to work within an Azure SQL environment.
Before this change, the library always connects to the default database (
masterin our case). If the database we want to connect to is another database, then Azure SQL will fail, as it restrict the connection to the database you are initially connected to (so in this casemaster). So this PR sets the database name for the connection to the database we're actually interested in. That way, theUSEstatement won't be denied by Azure SQL.Fixes #9 (and the related issue we are encountering as described in dimitri/pgloader#1324 (comment))