Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix atp #127

Merged
merged 8 commits into from
Apr 2, 2024
Merged

bug fix atp #127

merged 8 commits into from
Apr 2, 2024

Conversation

mfleader
Copy link
Member

@mfleader mfleader commented Apr 1, 2024 •
edited
Loading

Changes introduced with this PR

  • Add appropriate type casts from text string to binary string.
  • Fix race condition in test_atp.py.

By contributing to this repository, I agree to the contribution guidelines.

@mfleader mfleader changed the title encode string as bytes with utf bug fix atp Apr 2, 2024
@mfleader mfleader requested review from jaredoconnell and webbnh April 2, 2024 19:53
@mfleader mfleader marked this pull request as ready for review April 2, 2024 19:54
@mfleader mfleader requested a review from dbutenhof April 2, 2024 19:56
jaredoconnell
jaredoconnell approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as discussed during the call.

webbnh
webbnh approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfleader mfleader merged commit f453b25 into main Apr 2, 2024
4 checks passed
@mfleader mfleader deleted the bug-atp branch April 2, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@webbnh webbnh webbnh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfleader @webbnh @jaredoconnell @dbutenhof