Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oneof refactor 2 #126

Merged
merged 18 commits into from
Apr 3, 2024
Merged

Oneof refactor 2 #126

merged 18 commits into from
Apr 3, 2024

Conversation

mfleader
Copy link
Member

@mfleader mfleader commented Apr 1, 2024 •
edited
Loading

Changes introduced with this PR

Factor out some basic dataclasses so they can be used across multiple Test Classes.

By contributing to this repository, I agree to the contribution guidelines.

@mfleader mfleader marked this pull request as ready for review April 1, 2024 17:05
@mfleader mfleader marked this pull request as draft April 1, 2024 17:05
@mfleader mfleader marked this pull request as ready for review April 2, 2024 20:13
@mfleader mfleader self-assigned this Apr 2, 2024
webbnh
webbnh approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just have a couple of thoughts for your consideration.

src/arcaflow_plugin_sdk/test_schema.py Outdated Show resolved Hide resolved
src/arcaflow_plugin_sdk/test_schema.py Outdated Show resolved Hide resolved
dbutenhof
dbutenhof approved these changes Apr 3, 2024
View reviewed changes
Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably OK, if it quacks like a duck, but maybe I'm just confused about the context of some type references. (Which I thought I'd posted yesterday, although clearly I didn't...)

src/arcaflow_plugin_sdk/test_schema.py Outdated Show resolved Hide resolved
src/arcaflow_plugin_sdk/test_schema.py Outdated Show resolved Hide resolved
@mfleader mfleader requested review from webbnh and dbutenhof April 3, 2024 15:51
webbnh
webbnh approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good..but there's one little thing....

src/arcaflow_plugin_sdk/test_schema.py Outdated Show resolved Hide resolved
src/arcaflow_plugin_sdk/test_schema.py Outdated Show resolved Hide resolved
webbnh
webbnh approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@mfleader mfleader merged commit 93ac306 into main Apr 3, 2024
4 checks passed
@mfleader mfleader deleted the oneof-refactor-2 branch April 3, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@webbnh webbnh webbnh approved these changes

Assignees

@mfleader mfleader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfleader @webbnh @jaredoconnell @dbutenhof