Since the push is unconditional, make login match #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
requested review from
dustinblack,
jaredoconnell,
jdowni000,
dbutenhof and
mfleader
mfleader
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
The
reusable_workflow.yamlworkflow unconditionally pushes the container image to Quay; however, it currently only performs a login if themulti_archistrue. This means that, ifmulti_archisfalse, the workflow will presumably fail (as the CI for arcalot/arcaflow-plugin-aws-ec2-control#50 currently does). (@dustinblack, @jdowni000: I'm curious as to how/why the code evolved to this state.)This change removes the conditional from the login step: just as we unconditionally build and push the image, we will now unconditionally log in, first.
By contributing to this repository, I agree to the contribution guidelines.