Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure code compiles on all supported platforms #75

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Conversation

whereswaldon
Copy link
Member

This PR makes TravisCI attempt to build our code for windows, darwin, linux, and openbsd after every change, which should prevent us from being unaware when compilation fails on a specific supported OS (e.g. @Caton101 realizing that I broke the build on Windows).

I did not include dragonflybsd, freebsd, or netbsd because they all failed to compile one of our dependencies. It looks like we might not be able to support them and also rely on godbus. I think that's probably a separate discussion though.

@BitiTiger
Copy link
Contributor

BitiTiger commented Jan 9, 2019 via email

@whereswaldon
Copy link
Member Author

@Caton101 I get this when I attempt to build it:

env GOOS=freebsd go build
# github.com/arborchat/muscadine/vendor/github.com/godbus/dbus
vendor/github.com/godbus/dbus/transport_unix.go:52:3: cannot use t (type *unixTransport) as type transport in return argument:
        *unixTransport does not implement transport (missing SendNullByte method)
vendor/github.com/godbus/dbus/transport_unix.go:58:3: cannot use t (type *unixTransport) as type transport in return argument:
        *unixTransport does not implement transport (missing SendNullByte method)

It's possible that this problem has been fixed in godbus, but that we aren't on the latest version.

Copy link
Contributor

@jwhett jwhett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺

@whereswaldon
Copy link
Member Author

@Caton101 I think we should definitely try to get it building on those BSD platforms consistently, but that's not a reason to wait on ensuring that it builds for the ones listed in this PR. We can add the others as we have the opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants