Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API Error Handling, etc #467

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

itutu-tienday
Copy link
Collaborator

@itutu-tienday itutu-tienday commented Oct 12, 2024

Contents

  • Improve API Error Handling

    • Improved error handling in both backend and frontend when an exception occurs in some APIs, as it was insufficient in some APIs.
      • backend ... Improved error handling and organized HTTP response codes
      • frontend ... Appropriate message display in case of error
  • Others

  • Related

Testcase

The detailed Testcase is below

  • If an Error occurs in the BackEnd (API) for the following operation, the error message (Snackbar) is properly displayed in the FrontEnd
    • Workflow Run API error
    • Workflow Fetch API error
    • Experiment Reproduce API error
    • Experiment Rename API error
    • Experiment Delete API error
    • Edit Roi Commit API error

However, since the above cases do not usually occur, the normal operation check is OK.

  • Normal testcase
    • Workflow Screen
      • Run
      • Run All
    • Experiment Screen
      • Reproduce
      • Rename
      • Delete
    • Visualize Screen
      • Edit Roi

@itutu-tienday itutu-tienday marked this pull request as ready for review October 15, 2024 01:35
Copy link
Collaborator

@tsuchiyama-araya tsuchiyama-araya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードを確認したところ、問題ないかと思います。
動作確認は明日の朝に実行したいと思います。

まだ、動作確認はしていないですが、問題なさそうなので、一旦承認します。

Copy link
Collaborator

@milesAraya milesAraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked run, run all, edit roi.

@itutu-tienday itutu-tienday merged commit 5aee148 into develop-main Oct 24, 2024
5 checks passed
@itutu-tienday itutu-tienday deleted the feature/improve-api-error-handling branch October 31, 2024 08:26
@itutu-tienday itutu-tienday added this to the ver1.2.2 milestone Nov 1, 2024
itutu-tienday pushed a commit to arayabrain/optinist-for-server that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants