forked from oist/optinist
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update node params #466
Open
milesAraya
wants to merge
10
commits into
develop-main
Choose a base branch
from
feature/update-node-params
base: develop-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6cea46
to
5a9f4ce
Compare
At first check the following
|
Ah yes, I will need to updated the tutorials. |
…ues (GLM more error logging, Granger robust response to regresults selection)
final updates final updates
92c197f
to
7851c9f
Compare
milesAraya
commented
Feb 6, 2025
f91f3bf
to
8f88230
Compare
Screen.Recording.2025-02-06.at.12.30.10.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
パラメータ構造を一貫性のあるものに更新しました。
I updated the parameter structure to be consistent.
失敗の原因となっていたGLMのバグも修正しました。
I also fixed a bug with with GLM that caused failure.
And added some checks in Granger to account for occasional bugs in adfuller
また、adfullerの時折発生するバグを考慮し、Grangerにいくつかのチェックを追加しました。
dPCA node is not working well. I think it needs to be redesigned. This should be done in a separate PR
dPCAはうまく動作していないノードです。再設計が必要だと思います。これは別のPRで行うべきです。