Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update node params #466

Open
wants to merge 10 commits into
base: develop-main
Choose a base branch
from

Conversation

milesAraya
Copy link
Collaborator

パラメータ構造を一貫性のあるものに更新しました。
I updated the parameter structure to be consistent.

失敗の原因となっていたGLMのバグも修正しました。
I also fixed a bug with with GLM that caused failure.

if iscell is not None:
        iscell = iscell.data
        ind = np.where(iscell > 0)[0]
        X = X[:, ind]
        # Y = Y[:, ind]

And added some checks in Granger to account for occasional bugs in adfuller
また、adfullerの時折発生するバグを考慮し、Grangerにいくつかのチェックを追加しました。

dPCA node is not working well. I think it needs to be redesigned. This should be done in a separate PR
dPCAはうまく動作していないノードです。再設計が必要だと思います。これは別のPRで行うべきです。

Screenshot 2024-10-10 at 17 43 36

@milesAraya milesAraya added bug Something isn't working enhancement New feature or request backend labels Oct 10, 2024
@milesAraya milesAraya self-assigned this Oct 10, 2024
@milesAraya milesAraya added this to the OIST requirements 2024 milestone Dec 26, 2024
@milesAraya milesAraya force-pushed the feature/update-node-params branch from f6cea46 to 5a9f4ce Compare December 26, 2024 11:33
@itutu-tienday
Copy link
Collaborator

At first check the following

  • suite2p -> OK
  • caiman -> OK
  • Tutorial 1,2 -> NG (probably due to change in parasm configuration)

@milesAraya
Copy link
Collaborator Author

Ah yes, I will need to updated the tutorials.
I am also updating the tutorials in Caiman version up.
Maybe I should merge caiman version up and parameter branches and then pull into develop-main?

@milesAraya
Copy link
Collaborator Author

I checked the outputs of eta, pca, cca, tsne.
No mathematical differences in output.
Screenshot 2025-01-27 at 19 03 49

@milesAraya milesAraya force-pushed the feature/update-node-params branch from 92c197f to 7851c9f Compare January 29, 2025 05:22
@milesAraya milesAraya force-pushed the feature/update-node-params branch from f91f3bf to 8f88230 Compare February 6, 2025 03:28
@milesAraya
Copy link
Collaborator Author

Screen.Recording.2025-02-06.at.12.30.10.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants