#15: Publish multiple commands #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apetkov-so
requested review from
elagergren-spideroak,
chip-so,
jdygert-spok,
gknopf-aranya and
ssweetney-spok
|
Add test that publishes multiple types of commands (per @gknopf-aranya) |
apetkov-so
force-pushed
the
15-publish-multiple-commands-from-action
branch
from
2dcc829 to
726b3b2
Compare
- The VM now `Yield`s to the runtime when it publishes a command. The runtime is responsible for sealing the command, updating the facts database, then resuming the VM so it can process the next command. - FFI `call`s now take an immutable self.
…nState (to potentially publish more). But the context's head_id needed to be updated to the new command's ID - this is now being done. That was difficult with the context being a reference, because the new context doesn't live long enough. So the RunState now owns the context.
apetkov-so
force-pushed
the
15-publish-multiple-commands-from-action
branch
from
c971a30 to
74ded88
Compare
apetkov-so
force-pushed
the
15-publish-multiple-commands-from-action
branch
from
4c3afc1 to
cd96acd
Compare
apetkov-so
force-pushed
the
15-publish-multiple-commands-from-action
branch
from
cd96acd to
cc082d8
Compare
chip-so
reviewed
Jan 17, 2025
| @@ -1414,6 +1414,8 @@ fn should_create_clients_with_args() { | |||
| assert_eq!(effects, expected); | |||
| } | |||
|
|
|||
| /// Test for <https://git.spideroak-inc.com/spideroak-inc/flow3-rs/issues/917>. | |||
There was a problem hiding this comment.
Since we're working in the public repo, this should probably point to a public issue or just refer to the issue without a URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yields to the runtime when it publishes a command. The runtime is responsible for sealing the command, updating the facts database, then resuming the VM so it can process the next command.calls now take an immutable self.