Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: more adapter housekeeping #26

Merged
merged 20 commits into from
Jul 21, 2022
Merged

new: more adapter housekeeping #26

merged 20 commits into from
Jul 21, 2022

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Jun 30, 2022 •
edited
Loading

  • add debug logs on individual node/edge level
  • update README
  • package config cleanup
  • new __insert_adb_docs method
  • clean up arangodb_to_dgl and dgl_to_arangodb
  • clean up etypes_to_edefinitions

@aMahanna aMahanna self-assigned this Jun 30, 2022
@cw00dw0rd
Copy link

Discussed in person:

  • Investigate python-arango logging
  • Use logging for better error handling as well

@aMahanna
cleanup
916856f
@aMahanna
config cleanup
2c128e4
@aMahanna
fix: typo
97f843f
@aMahanna
new: __insert_adb_docs
7dd9ac2 
also: cleans up node/edge insertion in ArangoDB to DGL
@aMahanna
Update setup.cfg
569ec27
@aMahanna
Update conftest.py
9e631a5
@aMahanna
cleanup: __fetch_adb_docs
da24932 
was complicating things for no reason
@aMahanna
cleanup & fix: etypes_to_edefinitions
4038f9f 
also:
@aMahanna
fix: mypy
fbeb8f2
@aMahanna
fix: metagraph example
7244e6b
@aMahanna
new: remove ValueError exception
f1b8bae 
I was under the impression that working with an ArangoDB edge collection that had multiple "from" and "to" vertex types was not possible to convert to DGL. This commit allows for it
@aMahanna
fix: black
578562b
@aMahanna aMahanna changed the title new: add debug logs on individual node/edge level new: more adapter housekeeping Jul 5, 2022
@aMahanna aMahanna merged commit 5d98756 into master Jul 21, 2022
@aMahanna aMahanna deleted the feature/increase-debug-logging branch July 21, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cw00dw0rd cw00dw0rd cw00dw0rd approved these changes

Assignees

@aMahanna aMahanna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aMahanna @cw00dw0rd