bug fix #723
Merged
bug fix #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 28. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors hardcoded test endpoints to use dynamically constructed values from the TEST_ENDPOINTS environment variable, and fixes pointer comparison issues in access token tests. The changes make tests more flexible and environment-aware, but introduce critical bugs in the endpoint conversion logic.
- Adds helper functions
getApplierEndpointandgetSyncEndpointto convert HTTP/HTTPS endpoints to their respective protocol formats (tcp://, ssl://, http+tcp://, https+ssl://) - Replaces all hardcoded endpoint strings in replication tests with calls to these helper functions
- Fixes pointer dereferencing in access token comparison tests and adds
Parallel: falseoption
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| v2/tests/client_replication_test.go | Introduces endpoint conversion helper functions and replaces 6 hardcoded endpoint strings with dynamic calls |
| v2/tests/client_access_tokens_test.go | Corrects require.Equal calls to compare dereferenced pointer values and disables parallel execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
jwierzbo
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.