Skip to content

Conversation

@bluepal-prasanthi-moparthi
Copy link
Collaborator

@bluepal-prasanthi-moparthi bluepal-prasanthi-moparthi commented Dec 1, 2025

… without V8


Note

Gates V8-dependent v2 tests with a new requireV8Enabled/version skips, adjusts some test timeouts/assertions, and bumps CircleCI x86 executor resources.

  • Tests (v2)
    • Add requireV8Enabled(...) gate and apply it to V8-dependent tests: async jobs (pending/delete/expired), Foxx, tasks, UDFs, JS transactions, and routing/script admin ops.
    • Introduce/centralize requireV8Enabled helper in v2/tests/util_test.go.
    • Adjust timeouts to defaultTestTimeout in multiple admin tests; add non-parallel WrapOptions where needed.
    • Relax CallWithChecks assertion to accept 404 or 501.
    • Minor flow tweaks (e.g., require cluster earlier, increased waits) and additional serializations/logs.
  • Tests (v1)
    • Skip V8-dependent parts on server versions >= 4.0 in test/asyncjob_test.go and database_transaction_test.go.
  • Client (v2)
    • Clarify ReloadRoutingTable doc to mention Foxx services rebuilding routes.
  • CI
    • Increase CircleCI x86-machine-executor resource_class to large.

Written by Cursor Bugbot for commit 0a0d3ea. This will update automatically on new commits. Configure here.

@cla-bot cla-bot bot added the cla-signed label Dec 1, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@bluepal-prasanthi-moparthi bluepal-prasanthi-moparthi force-pushed the feature/disable_v8_version_tests branch from d23b95e to cb2476a Compare December 5, 2025 13:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the go-driver for future ArangoDB versions (4.0+) that will ship without V8 JavaScript engine support by gating V8-dependent tests. The implementation uses two different strategies: V2 employs feature detection via the requireV8Enabled helper that checks the server's v8-version field, while V1 uses version-based skipping via skipIfVersionGTE for versions >= 4.0. Additionally, the PR includes minor improvements such as relaxing an HTTP status assertion, clarifying documentation, standardizing timeouts, and increasing CI resources.

  • Added requireV8Enabled helper to V2 that checks v8-version in server details
  • Added skipIfVersionGTE helper to V1 for version-based test skipping (>= 4.0)
  • Gated V8-dependent tests: Foxx, UDFs, JS transactions, tasks, async job pending/delete operations
  • Relaxed CallWithChecks test to accept both 404 and 501 status codes
  • Clarified ReloadRoutingTable documentation to mention Foxx routing rebuild
  • Standardized test timeouts to use defaultTestTimeout constant

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
v2/tests/util_test.go Added requireV8Enabled helper function to check if V8 is enabled via version details
v2/tests/tasks_test.go Added V8 guards to task creation tests
v2/tests/foxx_test.go Added V8 guards to Foxx service tests
v2/tests/database_transactionsjs_test.go Added V8 guard to JavaScript transaction tests
v2/tests/database_query_test.go Added V8 guard to user-defined function tests
v2/tests/call_test.go Relaxed status assertion to accept 404 or 501 for non-existent endpoints
v2/tests/asyncjob_test.go Added V8 guards to async job pending and delete tests
v2/tests/admin_test.go Added V8 guards to routing table reload and admin script tests; standardized timeouts
v2/tests/admin_cluster_test.go Moved requireClusterMode check outside Wrap for consistency
v2/arangodb/client_admin.go Clarified ReloadRoutingTable documentation to mention Foxx routing rebuild
test/database_transaction_test.go Added version skip for >= 4.0 to JavaScript transaction tests
test/client_test.go Added skipIfVersionGTE helper for version-based test skipping
test/asyncjob_test.go Added version skips for >= 4.0 to async job tests using JS transactions
.circleci/config.yml Increased x86 machine executor to large resource class

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants