Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to 1.2.52 results in no icons #234

Closed
lwsrbrts opened this issue Dec 13, 2023 · 9 comments
Closed

Updating to 1.2.52 results in no icons #234

lwsrbrts opened this issue Dec 13, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@lwsrbrts
Copy link

Describe the bug
After updating to 1.2.52 there are no hue icons displayed anywhere in the dashboard(s) in Firefox.

To Reproduce
Steps to reproduce the behavior:
Update to 1.2.52 via HACS.
Reload as per HACS request.

Also attempted to:

  • Clear cache
  • Force reload any dashboard
  • F12 developer tools and select to "Disable Cache" then reload dashboards.

None of which results in the icons being displayed.

Expected behavior
The icons to be displayed where configured in the existing dashboard.

Screenshots
No icons are displayed for any configuration that uses them.

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Firefox
  • Version: 120.0.01

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Attempted loads of things before finally reverting to 1.2.51 which worked immediately after reloading via HACS prompt.

@lwsrbrts lwsrbrts added the bug Something isn't working label Dec 13, 2023
@arallsopp
Copy link
Owner

Eek. That doesn't sound good. Perhaps I missed a step. Let me check.

@lwsrbrts
Copy link
Author

I didn't add screenshots but... this is using 1.2.51 (taken 30 seconds ago)
image

And, having just updated again, I see this...
image

@arallsopp
Copy link
Owner

I may try to pull that last release until I can diagnose or recreate. Thanks for raising this.

@arallsopp
Copy link
Owner

I see it. Error in my javascript. I shall put on my "look at me, what an idiot" hat and wear it until fixed.

arallsopp added a commit that referenced this issue Dec 13, 2023
@arallsopp
Copy link
Owner

Hey, can you try v1.2.53 and let me know if that resolves it for you?

@NicoMalm
Copy link

The icons are back with v1.2.53. Thanks!!!

@lwsrbrts
Copy link
Author

Sorry, I got distracted with some new toys.

Ooh, flattery too!
image

Thank you. All looks good to me on 1.2.53!

@arallsopp
Copy link
Owner

Thanks to you and @NicoMalm. Really appreciate you catching this.

@lwsrbrts
Copy link
Author

As do we appreciate the work you've put in to this. Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants