Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4 new icons #191

Closed
HunterX86 opened this issue Jun 9, 2022 · 7 comments
Closed

Add 4 new icons #191

HunterX86 opened this issue Jun 9, 2022 · 7 comments
Assignees
Labels
icon request new custom icon

Comments

@HunterX86
Copy link

What is the specific model of hue fixture/bulb that you want an icon for
sultan group

Provide a URL that points to an image of this fixture/bulb
bulb-group-alt.zip

Additional context

@HunterX86 HunterX86 added the icon request new custom icon label Jun 9, 2022
@arallsopp
Copy link
Owner

arallsopp commented Jun 10, 2022

Hey @HunterX86. Did you create these?

Got to be honest, I'm apprehensive about adding icons from third parties, as I've had my own work here stolen without credit, and it leaves a bad taste in the mouth. Even more annoyingly, its left me mistrusting of people, which is no fun.

I'd be happy to create a 3 bulb group of sultans in hung/off variants. There's always a fair chunk of clean up to get things into a single path svg file anyway, so its not particularly extra work.

If these are your design, I'll credit you for their origination. If not, I'll credit you for the suggestion.

OK?

Edit: Also, am sorry to be repaying your contribution with unexpected queries. I'll get these icons for you one way or another, but need to be sure I'm not about to lose the seat on my high horse :)

@HunterX86
Copy link
Author

Thnx for adding all of the icons.
You can give me credits for my creations.

Also, am sorry to be repaying your contribution with unexpected queries. I'll get these icons for you one way or another, but need to be sure I'm not about to lose the seat on my high horse :)

I don't mind that, i do it for fun.

@arallsopp
Copy link
Owner

Sorry, been travelling.

Looking to add these to the next release. Am tweaking a little based upon the standards I've used in the other icons created here, and will name them bulb-group-sultan-3 / hung / off

@HunterX86
Copy link
Author

that's fine.
thnx.

arallsopp added a commit that referenced this issue Jun 16, 2022
@arallsopp
Copy link
Owner

arallsopp commented Jun 16, 2022

They're coming, plus the off variants. Release will be this afternoon as I'm overdue :)

@HunterX86
Copy link
Author

that's great thnx.
i'm closing this is issue.

arallsopp added a commit that referenced this issue Jun 16, 2022
@arallsopp
Copy link
Owner

@HunterX86: Thanks for the contribution. Very much appreciated. Your icons are now credited and available in release v.1.2.39.

Want to help the community?

If you like what you see and want to help others discover this repo, please consider giving it a free star. Every one of the 404 custom icons has been driven by a community request just like yours, and stars help people find this repo.

Want to get involved?

Its always good to see these icons being used. If you're proud of your dash, why not share a screenshot in the forum thread?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon request new custom icon
Projects
None yet
Development

No branches or pull requests

2 participants