Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications frontend #904
Notifications frontend #904
Changes from 16 commits
603384d
3bd241d
56249a7
a555477
53c0a6d
ce50333
83725be
d1a0424
1094ddd
4a6cf4d
997132b
3ec3dcb
46e759b
e3eb482
0df8fb7
33ac665
f472d3b
e94e361
3cc6d02
62d1867
8dcb3de
7fee586
c03b565
cfa1ed1
b83a16f
47aef63
790dd89
7ccf751
3dbb2bb
08aa412
1b51483
1140652
9b01a77
15f73f2
a054ba2
9e76df6
76ee465
ebf001d
ab682ea
c2afb65
2585472
b108200
6f99616
e8d7085
3df25fe
f7201a2
836df88
ed6c63b
6577afa
607747c
b2e2a46
d932092
bdb2ff6
6375f39
474c41a
fd24a56
26afff7
2a4bc57
e8b869f
ebe2512
5c8808b
9eec3e0
842a9b4
3ef0938
f4a2077
2bd21d8
2a1c1cc
442467c
ee7572e
b0fdc3a
e51e90b
34ac76e
b459901
55b77cb
ba0a363
c640eeb
23898b9
2d25aa0
fa0e691
5ba5b31
a1bfb22
352a7af
1b0fbf6
433ea60
122cab0
6554b8f
1ea0ccc
e7e6c8f
4034014
4975906
6dce2ee
f2a2fb8
0f88a81
88f6300
ff53022
295dbe8
b975615
93eed0c
87ecabc
484da85
a5f52ed
6564e7c
cb159c1
0911d01
a4e109b
2bda588
a3205d1
dfe4899
1992b1c
0f788d0
8eebf90
b8444bc
987d05b
1f1dec3
6bda0ca
aa813ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point we can assume these are both
truthy
no? No need for this check. Sorry, not true, email could befalsy
. Now I'm curious if that state could happen?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can't happen but for someone manipulating local storage. Do you think we should handle it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't worry about it happening, but because it could happen either have a last "default"
return null
or handling it specifically (last return is easiest, and if someone meddles withlocalStorage
they should know better)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets just double check what should be the correct spacing here:
cc @dizzypaty
and we can help out the user with some other message, I was thrown off by "Failed to fetch".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dizzypaty would it make sense to split this in 2 info boxes? Feels a bit crowded it does communicate two different messages: what is this and how this works on diff devices with no password: