Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL: Rollback v2 changes #606

Merged
merged 3 commits into from
Aug 4, 2020
Merged

ACL: Rollback v2 changes #606

merged 3 commits into from
Aug 4, 2020

Conversation

facuspagnuolo
Copy link
Contributor

I created this branch to continue working on the related aragonOS v6 changes, which includes the changes I'm rolling back in this PR of course.

@facuspagnuolo facuspagnuolo requested a review from sohkai August 3, 2020 15:28
@auto-assign auto-assign bot requested a review from izqui August 3, 2020 15:29
@facuspagnuolo facuspagnuolo self-assigned this Aug 3, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 98.881% when pulling 8d75656 on remove_acl_changes_from_v5 into 84f1c0d on next.

@facuspagnuolo facuspagnuolo requested review from bingen and removed request for izqui August 4, 2020 14:36
sohkai
sohkai approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I noticed a few changes on the ACL against master, but I think these are fine in terms of an audit. We won't be re-deploying the ACL anyway.

Screen Shot 2020-08-04 at 5 07 54 PM

@facuspagnuolo
Copy link
Contributor Author

Yea, I fixed some indentation and inline doc, agreed that it shouldn't affect

@facuspagnuolo facuspagnuolo merged commit d676f59 into next Aug 4, 2020
@facuspagnuolo facuspagnuolo deleted the remove_acl_changes_from_v5 branch August 4, 2020 19:16
@facuspagnuolo facuspagnuolo mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

@bingen bingen Awaiting requested review from bingen

Assignees

@facuspagnuolo facuspagnuolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facuspagnuolo @coveralls @sohkai