feat: addWebpackExternals #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FezVrasta
reviewed
Apr 21, 2019
readme.md
Outdated
| @@ -150,6 +150,10 @@ Adds the provided alias info into webpack's alias section. Pass an object litera | |||
|
|
|||
| Adds the provided resolve info into webpack's resolve section. Pass an object literal with as many entries as you'd like, and the whole object will be merged in. | |||
|
|
|||
| ### addWebpackExternals(deps) | |||
|
|
|||
| Add external dependencies, useful when trying to offload libs to CDN | |||
There was a problem hiding this comment.
May you provide a short example to explain how to use this?
There was a problem hiding this comment.
Here you go
https://webpack.js.org/configuration/externals/
facebook/create-react-app#2758
Should I add them to the documents?
There was a problem hiding this comment.
Ideally the example should be written directly in the document
There was a problem hiding this comment.
Also firebase js sdk https://firebase.google.com/docs/web/setup#reserved-urls with externals we can import firebase in js file also using the js firebase provided
|
@FezVrasta docs added. 😄 |
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.