Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang format #4585

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Fix clang format #4585

merged 2 commits into from
Feb 15, 2025

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Feb 12, 2025

1. Explain what the PR does

12a7e77 chore(ebpf): format apply based on the latest fix
d3fc3e1 fix: remove duplicate entry in .clang-format

d3fc3e1 fix: remove duplicate entry in .clang-format

PenaltyReturnTypeOnItsOwnLine was duplicated in the .clang-format file.
It was crashing the clangd server.

Since the value of PenaltyReturnTypeOnItsOwnLine was being wrongly
interpreted, this opportunistically changes the other Penalty* values.

2. Explain how to test it

3. Other comments

@geyslan
Copy link
Member Author

geyslan commented Feb 12, 2025

Copy link
Collaborator

@rscampos rscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PenaltyReturnTypeOnItsOwnLine was duplicated in the .clang-format file.
It was crashing the clangd server.

Since the value of PenaltyReturnTypeOnItsOwnLine was being wrongly
interpreted, this opportunistically changes the other Penalty* values.
@geyslan
Copy link
Member Author

geyslan commented Feb 15, 2025

/fast-forward

@github-actions github-actions bot merged commit 12a7e77 into aquasecurity:main Feb 15, 2025
41 checks passed
@geyslan geyslan deleted the fix-clang-format branch February 18, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants