-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebpf: add a new required dependency field. #1707
ebpf: add a new required dependency field. #1707
Conversation
6332704
to
2b75a4f
Compare
Marking an event as required will make it so failing to attach it will fail tracee. Otherwise, tracee will continue to load as usual and log the failure. Now events can be loaded with partial dependencies.
2b75a4f
to
b994ec5
Compare
I think that what should be marked as required or not is the probe, and not the event. |
Agreed, so I'll post here what we discussed offline. So this PR will wait on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved this accidentally. Still needs review.
I approved this accidentally. Still needs review.
@NDStrahilevitz this PR needs to be rebased on main as probes are now flatten (like we previously discussed) |
I am closing this in favor of the fix i've done in #1791 |
Initial Checklist
Description (git log)
Marking an event as required will make it so failing to attach it's probe will fail tracee.
Otherwise, tracee will continue to load as usual and simply log the failure.
Now events can be loaded with partial dependencies.
Fixes: #1622
Type of change
New feature (non-breaking change adding functionality).
I've marked event dependencies that I think should be required as such, but I'm not 100% confident that I got it right on the first go. So anyone reviewing should pay extra attention to that :)
In addition, the previously named "essential" events have been marked as required, and a function for handling all initial required events was extracted out of
New
intoinitRequiredEvents
. There may also be edge cases there to watch for.How Has This Been Tested?
This hasn't been tested yet. It will be tested on a reported GKE environment where tracee failed to load the
VfsWritev
event. After testing thatmagic_write
can be loaded there I will report back here.Final Checklist:
Pick "Bug Fix" or "Feature", delete the other and mark appropriate checks.
Git Log Checklist:
My commits logs have: