Skip to content

Commit

Permalink
fix: performance yaml (#4036)
Browse files Browse the repository at this point in the history
1. Downgrade AWS authentication v3
(see aws-actions/configure-aws-credentials#862)
2. Add missing needs label to the benchmark job
  • Loading branch information
NDStrahilevitz authored May 9, 2024
1 parent 134f281 commit 0027d78
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/performance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: [self-hosted, perf]
steps:
- name: AWS Authentication
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2
uses: aws-actions/configure-aws-credentials@50ac8dd1e1b10d09dac7b8727528b91bed831ac0 # v3.0.2
env:
AWS_PROFILE: ${{ secrets.AWS_PROFILE }}
with:
Expand All @@ -40,10 +40,12 @@ jobs:
docker push $PR_REPO:$GITHUB_SHA
network-benchmark:
name: Network Performance Gate
needs:
- publish-pr-image
runs-on: [self-hosted, perf]
steps:
- name: AWS Authentication
uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2
uses: aws-actions/configure-aws-credentials@50ac8dd1e1b10d09dac7b8727528b91bed831ac0 # v3.0.2
env:
AWS_PROFILE: ${{ secrets.AWS_PROFILE }}
with:
Expand Down

0 comments on commit 0027d78

Please sign in to comment.