Wrap `bpf_prog_attach` and `bpf_prog_detach2` #335

mozillazg · 2023-06-16T13:42:33Z

rafaeldtinoco · 2023-06-21T07:29:17Z

libbpfgo.go

+)
+
+// Attach attaches the BPFProgram to a targetFd at the specified attachType hook.
+func (p *BPFProg) Attach(targetFd int, attachType BPFAttachType, flags AttachFlag) error {


We have AttachGeneric which is similar, but does not allow to specify a fd to attach to. Should we name this AttachGenericFD?

I also see that you're using it for attaching a program to a cgroupFD (Which could be done by the attach_cgroup method, no ?). I want to understand if:

should we make attachgeneric generic enough to allow a fd to attach to ? (or is it just the cgroup case and then we already have an attachment function for it that could be used and/or changed)

this is a specific need for something else (then we should either change AttachGeneric OR the selftest to differentiate between the cgroup attachment).

WDYT ?

We have AttachGeneric which is similar, but does not allow to specify a fd to attach to. Should we name this AttachGenericFD?

SGTM. I'll rename it to AttachGenericFD.

I also see that you're using it for attaching a program to a cgroupFD (Which could be done by the attach_cgroup method, no ?)

That program can't be attached by the attach_cgroup method.

should we make attachgeneric generic enough to allow a fd to attach to ? (or is it just the cgroup case and then we already have an attachment function for it that could be used and/or changed)

That would be a breaking change and would make the attachgeneric method very complex. we should avoid it.

this is a specific need for something else (then we should either change AttachGeneric OR the selftest to differentiate between the cgroup attachment).

Yes, This is a specific method for attaching cgroup, sockops, flow_dissector, lirc_mode2, and sockmap programs.
I'll change the selftest to attach a sockmap program.

mozillazg · 2023-06-29T14:04:20Z

@rafaeldtinoco ping~

rafaeldtinoco · 2023-06-29T15:54:21Z

@mozillazg sorry, been busy with our tracee release.

rafaeldtinoco

LGTM

rafaeldtinoco · 2023-06-29T15:57:16Z

Thanks for your contribution, as always.

rafaeldtinoco reviewed Jun 21, 2023

View reviewed changes

mozillazg force-pushed the feature/wrap-attach-and-detach branch from 6c516ad to a2bbae9 Compare June 21, 2023 13:43

Wrap bpf_prog_attach and bpf_prog_detach2

47888e0

mozillazg force-pushed the feature/wrap-attach-and-detach branch from a2bbae9 to 47888e0 Compare June 21, 2023 13:50

mozillazg requested a review from rafaeldtinoco June 21, 2023 13:57

rafaeldtinoco approved these changes Jun 29, 2023

View reviewed changes

rafaeldtinoco merged commit ad00ee4 into aquasecurity:main Jun 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrap `bpf_prog_attach` and `bpf_prog_detach2` #335

Wrap `bpf_prog_attach` and `bpf_prog_detach2` #335

mozillazg commented Jun 16, 2023 •

edited

Loading

rafaeldtinoco Jun 21, 2023

rafaeldtinoco Jun 21, 2023

mozillazg Jun 21, 2023

mozillazg commented Jun 29, 2023

rafaeldtinoco commented Jun 29, 2023

rafaeldtinoco left a comment

rafaeldtinoco commented Jun 29, 2023

Wrap bpf_prog_attach and bpf_prog_detach2 #335

Wrap bpf_prog_attach and bpf_prog_detach2 #335

Conversation

mozillazg commented Jun 16, 2023 • edited Loading

rafaeldtinoco Jun 21, 2023

Choose a reason for hiding this comment

rafaeldtinoco Jun 21, 2023

Choose a reason for hiding this comment

mozillazg Jun 21, 2023

Choose a reason for hiding this comment

mozillazg commented Jun 29, 2023

rafaeldtinoco commented Jun 29, 2023

rafaeldtinoco left a comment

Choose a reason for hiding this comment

rafaeldtinoco commented Jun 29, 2023

Wrap `bpf_prog_attach` and `bpf_prog_detach2` #335

Wrap `bpf_prog_attach` and `bpf_prog_detach2` #335

mozillazg commented Jun 16, 2023 •

edited

Loading