Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: va_end() va_list copy rather than copied #286

Merged
merged 1 commit into from
Jan 15, 2023
Merged

fix: va_end() va_list copy rather than copied #286

merged 1 commit into from
Jan 15, 2023

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jan 13, 2023 •
edited
Loading

Each invocation of va_copy() must be matched by a corresponding invocation of va_end() in the same function.

https://man7.org/linux/man-pages/man3/va_arg.3.html

Fix:

@geyslan geyslan self-assigned this Jan 13, 2023
@geyslan geyslan marked this pull request as ready for review January 13, 2023 12:44
yanivagman
yanivagman approved these changes Jan 15, 2023
View reviewed changes
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit 8b1513e into aquasecurity:main Jan 15, 2023
@geyslan geyslan deleted the 285-fix-va_arg branch March 31, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@rafaeldtinoco rafaeldtinoco Awaiting requested review from rafaeldtinoco

Assignees

@geyslan geyslan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geyslan @yanivagman