-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AttachIter
to wrap bpf_program__attach_iter
#254
Conversation
c6bdb44
to
90a8515
Compare
@geyslan @grantseltzer I have no idea how to fix this error. Could you help me? Thanks! BTW, The selftests can be run successfully on my vagrant host. |
I'm taking a look now! @mozillazg |
@mozillazg thank you for your contribution 🙇🏼♂️. I reviewed the C part so far. Regarding the check error, we'll take a look soon, but if you are able to do some tests, try seeing if the header that declares
|
@mozillazg for your vagrant host do you mean the one provided by libbpfgo? -- EDIT We've just updated the main branch bumping versions. Could you please rebase this PR on top of it? Let's keep an eye in the check results again. Thanks. |
After merging the main branch all checks have passed. |
My apologies for the delay in getting to review this properly, will have good feedback for you by end of week! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it LGTM, just some handling over version control and API is required.
b33d2e0
to
871b2b4
Compare
@mozillazg I'm sorry this was left unattended. Is this still valid ? I'm converting to DRAFT just so you can rebase (and squash so many commits into meaningful ones) so we can review/merge it. Thank you!
|
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mozillazg Thank you so much for always contributing. |
#91