-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbpf: Added AttachXDP wrapper #170
Conversation
Hi @guyarb! My apologies for the delay in review, I was off all of last week. I'll be looking at this today. |
libbpfgo.go
Outdated
bpfLink := &BPFLink{ | ||
link: link, | ||
prog: p, | ||
linkType: Tracepoint, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that this is the correct link type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch! Added new link type XDP
I manually tested this and of course it works great, thanks for submitting! Just a comment and a question. I'd like to have a selftest for this but because it'll require an external program it can get complicated, not going to ask that of you. |
Co-authored-by: grantseltzer <[email protected]>
Changed the linkType field in the XDP BPFLink to XDP
I copied the selftest from |
Thank you @guyarb ! |
#171