-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iterator for bpf programs/maps in a bpf object #166
Conversation
Signed-off-by: grantseltzer <[email protected]>
selftest Signed-off-by: grantseltzer <[email protected]>
Signed-off-by: grantseltzer <[email protected]>
Reviewing this one... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are 2 minor fixes over Println
needed. Other than that, I think its good! Thanks.
selftest/object-iterator/main.go
Outdated
} | ||
for k, v := range expectedProgramNames { | ||
if v == false { | ||
fmt.Fprintln(os.Stderr, "did not iterate over expected program: %s", k) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fmt.Printf
instead (you're using %s)
selftest/object-iterator/main.go
Outdated
} | ||
for k, v := range expectedMapNames { | ||
if v == false { | ||
fmt.Fprintln(os.Stderr, "did not iterate over expected map: %s", k) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fmt.Printf
instead (you're using %s)
Signed-off-by: grantseltzer <[email protected]>
Plus a helper for getting section name, and a selftest