-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for arm64 #158
Fixes for arm64 #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I never noticed that we were missing this, strange that it's only in those 3 selftests. In the other selftests we have This is definitely a very welcome fix, and I want to make sure it's consistent across every selftest. |
Seems to work! :D
https://github.com/aquasecurity/libbpfgo/blob/main/selftest/tc/Makefile is a symlink to |
300fcd5
to
76e1bff
Compare
Removed a leftover arch=x86 variable |
On my dev machine: ``` $ uname -m arm64 ``` This PR addresses this and creates a `GO` Make variable to make it easy to override while trying golang binaries in non-standard paths **Test plan** ``` $ sudo make GO=/usr/local/go/bin/go run-dynamic [...] sudo ./run.sh main-dynamic [*] SUCCESS: all good ```
LGTM! |
On my dev machine:
This PR addresses this and creates a
GO
Make variable to make it easy tooverride while trying golang binaries in non-standard paths
Test plan
cc/ @Sylfrena @v-thakkar @kakkoyun