-
-
Notifications
You must be signed in to change notification settings - Fork 65
docs(registry): add musl vs glibc section to registry style guide #4756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+55
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
When wasvariantssupport added toaqua(minimum version)? Is it v2.58.0?💡 Result:
Variants support in aqua was added with the supported_envs feature (variants of OS/arch). The original implementation landed in v1.12.0 (merged June 18, 2022). Therefore, it is not tied to v2.58.0; v2.58.0 is far later than the version where variants/OS-arch environment support was introduced. Answer to your specific question: No, variants support was not first added in v2.58.0. It dates back to v1.12.0.
Citations:
Update version requirement for
variantssupport.Line 195 incorrectly states that
variantsrequires aqua >= v2.58.0. Variants support was actually added in v1.12.0 (June 18, 2022). Update the version requirement to reflect the actual minimum version where this feature was introduced.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is completely wrong. I'm not sure why you're misunderstanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suzuki-shunsuke, I apologize for the incorrect review comment. My web search conflated the general OS/arch variant support (viasupported_envs, added in v1.12.0) with the specificvariantsfield inoverridesregistry config, which is indeed a distinct, newer feature planned for v2.58.0. You are correct, and the version requirement in the documentation is accurate.(╯°□°)╯ (dropping my wrong conclusion)
✏️ Learnings added