Skip to content

fix: re-add env field to log#4629

Merged
suzuki-shunsuke merged 1 commit into
mainfrom
fix-env-log
Mar 11, 2026
Merged

fix: re-add env field to log#4629
suzuki-shunsuke merged 1 commit into
mainfrom
fix-env-log

Conversation

@suzuki-shunsuke

@suzuki-shunsuke suzuki-shunsuke commented Mar 11, 2026

Copy link
Copy Markdown
Member

Close #4624

Summary by CodeRabbit

  • Chores
    • Updated dependencies to latest versions, including authentication, CLI utilities, and logging packages for improved stability and security.

@suzuki-shunsuke suzuki-shunsuke added this to the v2.56.8 milestone Mar 11, 2026
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 20b2b372-8ba8-415d-9d82-df11dbb254e9

📥 Commits

Reviewing files that changed from the base of the PR and between 46ba9c4 and 7389ae7.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • cmd/aqua/main.go
  • go.mod

📝 Walkthrough

Walkthrough

The PR adds runtime environment exposure to the CLI startup by importing the runtime package and extending the urfave.Main invocation to pass an environment provider via the "env" flag. Several dependencies are updated to newer versions across go.mod.

Changes

Cohort / File(s) Summary
CLI Environment Provider
cmd/aqua/main.go
Adds runtime package import and extends urfave.Main to pass environment provider via "env" flag for startup-time environment exposure.
Dependency Updates
go.mod
Updates direct dependencies: slog-util (v0.3.1 → v0.3.2), urfave-cli-v3-util (v0.2.2 → v0.2.3), golang.org/x/oauth2 (v0.35.0 → v0.36.0); indirect dependency tint (v1.1.2 → v1.1.3).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A flutter of paws, a leap of joy,
Runtime whispers through the CLI toy,
Environment flows like morning dew,
Dependencies dance to versions anew!
Tiny hops, mighty code—hooray!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description provides only 'Close #4624' without following the required template structure, missing checklist items and detailed context required by the repository guidelines. Add the full checklist from the template, confirm adherence to contribution guidelines, and provide a link to the referenced issue and any relevant implementation details.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: re-add env field to log' directly describes the main change: re-adding an env field to logging functionality, which aligns with the code changes that add environment exposure via CLI in main.go.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-env-log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@suzuki-shunsuke suzuki-shunsuke enabled auto-merge (squash) March 11, 2026 23:39
@suzuki-shunsuke suzuki-shunsuke merged commit e05d995 into main Mar 11, 2026
21 of 22 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the fix-env-log branch March 11, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Env no longer included in log output

1 participant