feat: get pseudo-version from Go Proxy if no tagged version exists by gizmoguy · Pull Request #4422 · aquaproj/aqua

gizmoguy · 2025-12-18T04:44:45Z

Check List

Read CONTRIBUTING.md
- Read OSS Contribution Guide
Write a GitHub Issue before creating a Pull Request
- Link to the issue:
All commits are signed
- This repository enables Require signed commits, so all commits must be signed
Avoid force push
Do only one thing in one Pull Request

This PR fixes #4421 by adding the $module/@v/list go proxy API endpoint if @v/list API response is empty.

After this patch is applied, if you define a local registry like this:

packages:
  - type: go_install
    path: golang.org/x/perf/cmd/benchstat
    go_version_path: golang.org/x/perf

And attempt to install benchstat with:

$ aqua generate -i -g -s local,golang.org/x/perf/cmd/benchstat

We will now get a aqua.yaml that has a version set:

packages:
- name: golang.org/x/perf/cmd/benchstat@v0.0.0-20251208221838-04cf7a2dca90
  registry: local

I also tested and this works for upgrading go packages pinned to a pseudo-version with the aqua update command.

suzuki-shunsuke · 2025-12-23T08:18:05Z


+type InfoPayload struct {
+	Version string
+	Time    time.Time


Suggested change

Time time.Time

Time is unused.

suzuki-shunsuke · 2025-12-23T08:18:51Z

+func (c *Client) List(ctx context.Context, path string) ([]string, error) {
+	b, err := c.doHTTPRequest(ctx, fmt.Sprintf("https://proxy.golang.org/%s/@v/list", path))
+	if err != nil {
+		return nil, err


err should be wrapped to distinguish list and latest.

I see. When list API returns 404, doHTTPRequest returns an error, so latest API never calls.
We should continue the process while outputting debug log.

Ah, no logger is passed to List method as argument.
Hmm.

If the /list API endpoint returns 404, we know the /@latest endpoint will also return 404, so it is not required to query both endpoints.

I reverted the change. Thank you. c3473bb

suzuki-shunsuke · 2025-12-23T08:26:36Z

Hmm. It doesn't work.

$ go run ./cmd/aqua g golang.org/x/perf/cmd/benchstat
- name: golang.org/x/perf/cmd/benchstat
  version: '[SET PACKAGE VERSION]'

I added go_version_path: golang.org/x/perf/cmd/benchstat to https://github.com/aquaproj/aqua-registry/blob/main/pkgs/golang.org/x/perf/cmd/benchstat/registry.yaml , but the result wasn't changed. 🤔

https://aquaproj.github.io/docs/reference/registry-config/go-version-path/

suzuki-shunsuke · 2025-12-23T08:58:55Z

$ ~/go/bin/aqua -log-level debug g golang.org/x/perf/cmd/benchstat
DEBU[0000] ignore a package alias in the registry because the alias is duplicate  env=darwin/arm64 package_name= program=aqua program_version=v1.0.0-local registry_name=standard registry_package_alias=&{jreisinger/checkip} registry_package_name=jreisinger/checkip
DEBU[0000] retrieve package versions                     api_endpoint=https://proxy.golang.org/golang.org/x/perf/cmd/benchstat/@v/list env=darwin/arm64 error=unexpected status code: 404 program=aqua program_version=v1.0.0-local repository=/
DEBU[0000] retrieve package versions in 702.626125ms     env=darwin/arm64 program=aqua program_version=v1.0.0-local repository=/
WARN[0000] retrieve package versions                     api_endpoint=https://proxy.golang.org/golang.org/x/perf/cmd/benchstat/@latest env=darwin/arm64 error=list versions: retrieve the latest version: unexpected status code: 404 program=aqua program_version=v1.0.0-local repository=/
- name: golang.org/x/perf/cmd/benchstat
  version: '[SET PACKAGE VERSION]'

https://proxy.golang.org/golang.org/x/perf/cmd/benchstat/@latest returns 404.

suzuki-shunsuke · 2025-12-23T09:06:45Z

/@latest doesn't return pseudo-version.

$ curl "https://proxy.golang.org/github.com/suzuki-shunsuke/slog-error/@latest"
{"Version":"v0.2.1","Time":"2025-12-05T05:04:05Z","Origin":{"VCS":"git","URL":"https://github.com/suzuki-shunsuke/slog-error","Hash":"c24c9a12709d742f300f1633c079f661812ecf24","Ref":"refs/tags/v0.2.1"}}%                                                                               

$ curl "https://proxy.golang.org/golang.org/x/perf/cmd/benchstat/@latest"      
not found: module golang.org/x/perf/cmd/benchstat: no matching versions for query "latest"%

gizmoguy · 2025-12-23T09:46:06Z

Hmm. It doesn't work.
$ go run ./cmd/aqua g golang.org/x/perf/cmd/benchstat
- name: golang.org/x/perf/cmd/benchstat
  version: '[SET PACKAGE VERSION]'
I added go_version_path: golang.org/x/perf/cmd/benchstat to https://github.com/aquaproj/aqua-registry/blob/main/pkgs/golang.org/x/perf/cmd/benchstat/registry.yaml , but the result wasn't changed. 🤔

https://aquaproj.github.io/docs/reference/registry-config/go-version-path/

go_version_path must be set to the root go module path, so golang.org/x/perf for golang.org/x/perf/cmd/benchstat

The registry configuration needs to look like:

packages:
  - type: go_install
    path: golang.org/x/perf/cmd/benchstat
    go_version_path: golang.org/x/perf

suzuki-shunsuke · 2025-12-23T09:49:56Z

Ah, I see.

$ curl "https://proxy.golang.org/golang.org/x/perf/@latest"
{"Version":"v0.0.0-20251208221838-04cf7a2dca90","Time":"2025-12-08T22:18:38Z","Origin":{"VCS":"git","URL":"https://go.googlesource.com/perf","Hash":"04cf7a2dca90064b204731fae32fa4e221671c9a"}}%

suzuki-shunsuke · 2025-12-23T10:06:30Z

I confirmed it works as expected.

Before:

$ aqua -v
aqua version 2.55.3

$ aqua g golang.org/x/perf/cmd/benchstat
- name: golang.org/x/perf/cmd/benchstat
  version: '[SET PACKAGE VERSION]'

After:

$ ~/go/bin/aqua g golang.org/x/perf/cmd/benchstat
- name: golang.org/x/perf/cmd/benchstat@v0.0.0-20251208221838-04cf7a2dca90

suzuki-shunsuke · 2025-12-23T10:58:35Z

fix(golang.org/x/perf/cmd/benchstat): set go_version_path aqua-registry#46162

suzuki-shunsuke · 2025-12-23T11:08:40Z

🎉 https://github.com/aquaproj/aqua/releases/tag/v2.56.0

) This PR contains the following updates: | Package | Update | Change | Pending | |---|---|---|---| | [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.446.0` -> `v4.447.0` | `v4.448.0` (+1) | --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.447.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.447.0) [Compare Source](https://github.com/aquaproj/aqua-registry/compare/v4.446.0...v4.447.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.447.0) | [Pull Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.447.0) | <aquaproj/aqua-registry@v4.446.0...v4.447.0> #### 🎉 New Packages [#45755](https://github.com/aquaproj/aqua-registry/issues/45755) [tuist/tuist](https://github.com/tuist/tuist) - A toolchain to generate Xcode projects from Swift packages [@jdx](https://github.com/jdx) [#46040](https://github.com/aquaproj/aqua-registry/issues/46040) [jamf/Notifier](https://github.com/jamf/Notifier) - Swift project which can post macOS alert or banner notifications on 10.15+ clients [@TyceHerrman](https://github.com/TyceHerrman) [#45738](https://github.com/aquaproj/aqua-registry/issues/45738) [nektro/zigmod](https://github.com/nektro/zigmod) - Zig package manager [@jdx](https://github.com/jdx) #### Improvement [#46162](https://github.com/aquaproj/aqua-registry/issues/46162) golang.org/x/perf/cmd/benchstat: Set `go_version_path` [aquaproj/aqua#4422](https://github.com/aquaproj/aqua/pull/4422) #### Fixes [#46166](https://github.com/aquaproj/aqua-registry/issues/46166) Re-scaffold gohugoio/hugo [#46167](https://github.com/aquaproj/aqua-registry/issues/46167) Re-scaffold gohugoio/hugo/hugo-extended [#46168](https://github.com/aquaproj/aqua-registry/issues/46168) Re-scaffold steveyegge/beads [#46169](https://github.com/aquaproj/aqua-registry/issues/46169) stackrox/kube-linter: Fix cosign settings [#46173](https://github.com/aquaproj/aqua-registry/issues/46173) Fix redpanda-data/connect [#46198](https://github.com/aquaproj/aqua-registry/issues/46198) Re-scaffold maxpert/marmot [#46200](https://github.com/aquaproj/aqua-registry/issues/46200) mas-cli/mas: Support mas v4.0.0 or later [#46199](https://github.com/aquaproj/aqua-registry/issues/46199) Fix rest-sh/restish </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) in timezone Asia/Tokyo, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/izumin5210/dotfiles).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: izumin5210-update-aqua-checksum[bot] <169593670+izumin5210-update-aqua-checksum[bot]@users.noreply.github.com>

feat: get pseudo-version from Go Proxy if no tagged version exists

205e46a

szksh-lab-project-manager Bot added this to main Dec 18, 2025

suzuki-shunsuke mentioned this pull request Dec 23, 2025

Add support to aqua generate/update for finding version of go packages that have no git tags #4421

Closed

suzuki-shunsuke added the enhancement New feature or request label Dec 23, 2025

suzuki-shunsuke reviewed Dec 23, 2025

View reviewed changes

fix: call latest API after list API fails

531b89d

fix: return error if list api returns 404

c3473bb

refactor: fix a lint error

98dc2d9

suzuki-shunsuke added this to the v2.55.4 milestone Dec 23, 2025

suzuki-shunsuke merged commit 7b6162b into aquaproj:main Dec 23, 2025
20 checks passed

github-project-automation Bot moved this to Done in main Dec 23, 2025

gizmoguy deleted the go-pseudo-versions branch December 23, 2025 10:14

suzuki-shunsuke mentioned this pull request Dec 24, 2025

fix(golang.org/x/perf/cmd/benchstat): set go_version_path aquaproj/aqua-registry#46162

Merged

Uh oh!

Conversation

gizmoguy commented Dec 18, 2025

Check List

Uh oh!

suzuki-shunsuke Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

suzuki-shunsuke Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

suzuki-shunsuke Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

suzuki-shunsuke Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

gizmoguy Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

suzuki-shunsuke Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

suzuki-shunsuke commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suzuki-shunsuke commented Dec 23, 2025

Uh oh!

suzuki-shunsuke commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gizmoguy commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suzuki-shunsuke commented Dec 23, 2025

Uh oh!

suzuki-shunsuke commented Dec 23, 2025

Uh oh!

Uh oh!

suzuki-shunsuke commented Dec 23, 2025

Uh oh!

suzuki-shunsuke commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

suzuki-shunsuke commented Dec 23, 2025 •

edited

Loading

suzuki-shunsuke commented Dec 23, 2025 •

edited

Loading

gizmoguy commented Dec 23, 2025 •

edited

Loading