Repository navigation
fix(modem-dev/hunk): support windows/amd64 for >= v0.12.0-beta.2 - #58616
Merged
suzuki-shunsuke merged 4 commits intoAug 12, 2026
Merged
Conversation
On Windows, `aqua i` installed nothing and exited 0, because `supported_envs`
listed only `linux` and `darwin`, so aqua skipped the package as unsupported
on that environment.
hunk publishes `hunkdiff-windows-x64.tar.gz` from v0.12.0-beta.2 onwards, so
the trailing `version_overrides` entry is split rather than edited in place:
versions below that keep the linux/darwin-only `supported_envs`, and the
latest entry adds `windows/amd64`. Without the split, `aqua i` fails on the
older versions with `the asset isn't found: hunkdiff-windows-x64.tar.gz`.
I checked every hunk release: v0.12.0-beta.2 is the exact boundary. Every
release semver-below it lacks the Windows asset and every release from it
onwards has it, so no version is misclassified by either branch.
`windows/amd64` rather than bare `windows`, because hunk publishes no Windows
arm64 asset.
No `.exe` handling is needed: aqua appends the Windows extension to
`files[].src` itself, so the existing `{{.AssetWithoutExt}}/hunk` resolves to
`hunkdiff-windows-x64/hunk.exe`.
pkg.yaml pins v0.11.1 so CI exercises the new lower branch as well as the
latest one.
Co-authored-by: Claude <noreply@anthropic.com>
Generated by `argd gr`. Co-authored-by: Claude <noreply@anthropic.com>
Sponsor Our ProjectWe dedicate a significant amount of time every day to maintaining aqua and aqua-registry. |
Two review follow-ups, no behaviour change:
Spell the new boundary as `semver("<= 0.12.0-beta.1")` instead of
`semver("< 0.12.0-beta.2")`. The two are equivalent -- the only 0.12.0
prereleases are beta.0, beta.1 and beta.2, so nothing sorts between them --
but `<=` is what `argd s` generates for this package, matches the style note
in docs/guide.md, and matches the `<= 0.6.1` boundary already in this file.
Pin v0.12.0-beta.1 and v0.12.0-beta.2 in pkg.yaml so CI proves the boundary
from both sides: beta.1 is the last release without a Windows asset and must
be skipped on Windows, beta.2 is the first with one and must install there.
Previously the pinned versions all sat well away from the boundary this PR
is about.
Co-authored-by: Claude <noreply@anthropic.com>
Generated by `argd gr`. Co-authored-by: Claude <noreply@anthropic.com>
elucid
marked this pull request as ready for review
August 11, 2026 20:45
|
@suzuki-shunsuke Ready for review |
Member
|
Thank you! |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 18, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.550.0` → `v4.553.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.553.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.553.0) [Compare Source](aquaproj/aqua-registry@v4.552.0...v4.553.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.553.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.553.0) | <aquaproj/aqua-registry@v4.552.0...v4.553.0> #### 🎉 New Packages [#​58882](aquaproj/aqua-registry#58882) [uutils/sed](https://github.com/uutils/sed) - Rewrite of sed in Rust [@​yashikota](https://github.com/yashikota) [#​58935](aquaproj/aqua-registry#58935) [cloudsmith-io/cloudsmith-cli](https://github.com/cloudsmith-io/cloudsmith-cli) - Cloudsmith Command Line Interface (CLI) [@​cloudsmith-iduffy](https://github.com/cloudsmith-iduffy) ### [`v4.552.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.552.0) [Compare Source](aquaproj/aqua-registry@v4.551.0...v4.552.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.552.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.552.0) | <aquaproj/aqua-registry@v4.551.0...v4.552.0> #### 🎉 New Packages [#​58648](aquaproj/aqua-registry#58648) [OpenRouterLabs/ori-releases](https://github.com/OpenRouterLabs/ori-releases) - Ori CLI release repo [@​L0RD-ZER0](https://github.com/L0RD-ZER0) #### Security [#​58853](aquaproj/aqua-registry#58853) mekedron/wolt-cli: GitHub artifact attestations config [@​sanchpet](https://github.com/sanchpet) [#​58722](aquaproj/aqua-registry#58722) masutaka/github-nippou: update to 4.3.2, add GH artifact attestations config [@​scop](https://github.com/scop) ### [`v4.551.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.551.0) [Compare Source](aquaproj/aqua-registry@v4.550.0...v4.551.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.551.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.551.0) | <aquaproj/aqua-registry@v4.550.0...v4.551.0> #### 🎉 New Packages [#​58475](aquaproj/aqua-registry#58475) [mikevalstar/okq](https://github.com/mikevalstar/okq) - Fast, deterministic CLI to search and navigate Open Knowledge Format (OKF), or Obsidian style doc bundles — for humans and AI agents. Find by frontmatter, traverse the link graph, surface orphans/deadlinks [@​mikevalstar](https://github.com/mikevalstar) [#​58468](aquaproj/aqua-registry#58468) [mekedron/wolt-cli](https://github.com/mekedron/wolt-cli) - Free & Open Source CLI for Wolt: discover venues, inspect menus and options, manage carts, and preview checkout from the terminal [@​sanchpet](https://github.com/sanchpet) #### Fixes [#​58618](aquaproj/aqua-registry#58618) jgm/pandoc: Install pandoc-lua and pandoc-server where available [@​scop](https://github.com/scop) [#​58616](aquaproj/aqua-registry#58616) modem-dev/hunk: Support windows/amd64 for >= v0.12.0-beta.2 [@​elucid](https://github.com/elucid) [#​58400](aquaproj/aqua-registry#58400) anthropics/claude-code: Install from GitHub Releases and verify [@​nicwortel](https://github.com/nicwortel) [#​58596](aquaproj/aqua-registry#58596) kunobi-ninja/kunobi: Use GitHub release as version source [@​scop](https://github.com/scop) [#​58597](aquaproj/aqua-registry#58597) apstndb/spannerplanviz/rendertree: Use GitHub release ver src [@​scop](https://github.com/scop) [#​58615](aquaproj/aqua-registry#58615) apstndb/execspansql: Use GitHub release version source [@​scop](https://github.com/scop) #### Security [#​58423](aquaproj/aqua-registry#58423) matteo-sung/lockvet: GitHub artifact attestations config [@​scop](https://github.com/scop) [#​58482](aquaproj/aqua-registry#58482) stefanprodan/timoni: GitHub artifact attestations config [@​scop](https://github.com/scop) [#​58595](aquaproj/aqua-registry#58595) concourse/concourse/fly: checksum config [@​scop](https://github.com/scop) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yODguMCIsInVwZGF0ZWRJblZlciI6IjQzLjI4OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
argd scommand when adding new packagesThe bug
On Windows,
aqua iformodem-dev/hunkexits 0 and installs nothing.supported_envslists only
linuxanddarwin, so aqua skips the package as unsupported — a skip ratherthan an error, so there is no diagnostic and no
hunkcommand afterwards. hunk haspublished
hunkdiff-windows-x64.tar.gzsince v0.12.0-beta.2; this entry predates that.Fix
version_overridesentry:semver("<= 0.12.0-beta.1")keeps thelinux/darwin-only
supported_envs, and the"true"entry addswindows/amd64. Thesplit is required — appending
windows/amd64to the existing"true"entry turnstoday's silent skip into a hard
the asset isn't found: hunkdiff-windows-x64.tar.gzfailure for every release from v0.6.2 to v0.12.0-beta.1.
windows/amd64rather than barewindows, because hunk publishes no Windows arm64asset.
windows_arm_emulationis not set — untested, so out of scope here..exehandling is needed: aqua'scompleteWindowsExtToFileSrcappends the extension, so the existing
src: "{{.AssetWithoutExt}}/hunk"resolves tohunkdiff-windows-x64\hunk.exe.pkg.yaml: addedv0.12.0-beta.2,v0.12.0-beta.1andv0.11.1in long syntax, so CIcovers the new branch and both sides of the boundary. No existing test version was
removed and the updater-owned
modem-dev/hunk@v0.18.0line is untouched.Verification
argd t modem-dev/hunk— exit 0. Onwindows/amd64it installs v0.12.0-beta.2 andv0.18.0 and skips v0.12.0-beta.1 / v0.11.1 / v0.6.1;
windows/arm64skips cleanly. Thoseare the two
windows-latestlegs inwc-test.yaml. darwin and linux (amd64 + arm64)resolve exactly as before this change.
argd tonly simulates Windows viaAQUA_GOOS, so I also reproduced it on real hardware:Real Windows reproduction — environment,
aqua.yaml, before/afteraqua
2.62.3, Windows 11 Pro 25H2 build 26200, amd64 (env=windows/amd64), PowerShell5.1. The registry is fetched over aqua's real
github_contentpath pinned to this PR'shead commit, not a local file registry.
Before — current
main(ref: 608d3508d9). Expected hunk installed; actual exit 0,nothing installed:
After — this PR:
aqua whichis the interesting line: the entry never mentions.exe, and aqua stillresolved
hunk.exe.Full matrix on
windows/amd64— both sides of the boundary behave as intended:aqua ihunk --versionhunk.exe0.18.0hunk.exe0.12.0hunk.exe0.12.0-beta.2Without the version split, the same run against v0.11.1 fails hard:
On
argd sI ran
argd s modem-dev/hunkrather than hand-editing blind. The generated config omitsfiles[].srcfrom all threeversion_overridesbranches. hunk's binary is nested insidea directory in the archive (
hunkdiff-linux-x64/hunk), so withoutfiles[].srcnothinginstalls on any platform, and
argd tfails onlinux/amd64:This matches the note in
docs/guide.mdthatfilescannot be auto-generated. Itherefore followed
docs/guide.md→ "Modifying Existing Packages": starting from thegenerated output and restoring
files[].srcyields a config identical to this PR, whichpasses
argd tcleanly. Two things from the generated output I did not adopt:windows_arm_emulation: true(hunk ships no Windows arm64 asset, and I have not testedemulation) and the
v0.18.0→v0.18.1bump inpkg.yaml(that pin is owned byaqua-registry-updater).AI disclosure per docs/ai.md:
prepared with Claude Code, credited as a commit co-author. I reviewed the configuration
and reproduced every result above myself.