feat(ahkohd/oyo): scaffold ahkohd/oyo

[tmeijn]

#51459 ahkohd/oyo - A different viewer @tmeijn

Check List

• Read CONTRIBUTING.md
  • ⚠️ Avoid force push
  • ⚠️ Use argd s command when adding new packages
• Install and execute the package and confirm if the package works well (Not on Darwin)

Summary by CodeRabbit

Release Notes

• New Features
  • Added support for the oyo viewer tool (version v0.1.24) with platform-specific installation and configuration

[coderabbitai]

Warning

Rate limit exceeded

@suzuki-shunsuke has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 2 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 2 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 71a8a032-4e8e-4e6e-8ed6-e0e31ec97201

📥 Commits

Reviewing files that changed from the base of the PR and between 46b55db and 259ced1.

📒 Files selected for processing (2)

• pkgs/ahkohd/oyo/registry.yaml
• registry.yaml

📝 Walkthrough

Walkthrough

Adds package registry configuration for ahkohd/oyo across three YAML files: a local package manifest pinned to v0.1.24, a package-specific registry definition, and a main registry entry. Includes version-based overrides and platform-specific asset mappings.

Changes

Cohort / File(s)	Summary
Package registry configuration pkgs/ahkohd/oyo/pkg.yaml, pkgs/ahkohd/oyo/registry.yaml	Introduces package declaration (v0.1.24) and registry metadata for ahkohd/oyo with version overrides: disables asset fetching for versions ≤ 0.1.19; enables conditional asset downloads with platform/arch mappings for later versions.
Main registry entry registry.yaml	Adds github_release package entry with structured version constraints and asset selection rules, including conditional asset fetching and cross-platform identifier mappings (amd64↔x86_64, arm64↔aarch64, darwin↔apple-darwin).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• refactor: fix lint errors #50398: Implements identical registry configuration pattern with version_constraint: "false" and version-based asset override logic.
• feat(j178/prek): GitHub immutable release config #50075: Introduces similar github_release entries with version overrides and matching architecture/OS replacement mappings.

Suggested labels

enhancement

Poem

🐰 A new package hops into the registry today,
With version constraints in a structured way,
Platform mappings dance from darwin to gnu,
Assets conditionally bundled, old and new,
The oyo viewer finds its perfect place! 📦

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description includes a checked checklist item and mentions reading CONTRIBUTING.md, but lacks substantive details about the changes or the package being added.	Add details about what the ahkohd/oyo package does, why it's being added, and clarify whether the package was tested (the author notes 'Not on Darwin').

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: scaffolding a new package entry for ahkohd/oyo in the registry, which aligns with the file additions across pkg.yaml and registry.yaml files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pkgs/ahkohd/oyo/pkg.yaml`:
- Around line 1-2: pkg.yaml currently only lists the latest package entry
"ahkohd/oyo@v0.1.24", but registry.yaml contains multiple version_overrides so
add a second package entry to exercise the older override path: keep the
existing short form for v0.1.24 and add a new block using the long syntax
(object with name and version fields) for the older pinned version (e.g., name:
"ahkohd/oyo" and version: "0.1.X") so both code paths are tested; update the
packages array to include both entries.

In `@pkgs/ahkohd/oyo/registry.yaml`:
- Around line 3-21: The supported_envs field is nested inside the
version_overrides block so it only applies to the "true" override; move
supported_envs to the package top level (immediately after description and
before version_constraint) so it applies globally to the package. Update the
registry.yaml so supported_envs is no longer inside the version_overrides list
(remove it from the override that contains version_constraint: "true") and place
a top-level supported_envs: [darwin] field for the package; keep existing
version_overrides (including the semver("<= 0.1.19") no_asset entry and the
asset/format/replacements entries) unchanged except for removing their nested
supported_envs.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 357ac981-1734-460a-8747-ed0feacf284f

📥 Commits

Reviewing files that changed from the base of the PR and between 4d59d06 and 46b55db.

📒 Files selected for processing (3)

• pkgs/ahkohd/oyo/pkg.yaml
• pkgs/ahkohd/oyo/registry.yaml
• registry.yaml

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Add an older pinned package entry to cover the second override path.

pkg.yaml currently tests only v0.1.24, but this package has version-dependent behavior in registry.yaml. Add an old-version case as a separate entry, and use long syntax for the pinned old version.

Suggested update

 packages:
   - name: ahkohd/oyo@v0.1.24
+  - name: ahkohd/oyo
+    version: v0.1.19

Based on learnings: when registry.yaml has multiple version_overrides that exercise different configurations, pkg.yaml should include both latest and older versions; and old versions should use long syntax with an explicit version field.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@pkgs/ahkohd/oyo/pkg.yaml` around lines 1 - 2, pkg.yaml currently only lists
the latest package entry "ahkohd/oyo@v0.1.24", but registry.yaml contains
multiple version_overrides so add a second package entry to exercise the older
override path: keep the existing short form for v0.1.24 and add a new block
using the long syntax (object with name and version fields) for the older pinned
version (e.g., name: "ahkohd/oyo" and version: "0.1.X") so both code paths are
tested; update the packages array to include both entries.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Move supported_envs to package top level for darwin-only package.

The supported_envs constraint is currently nested inside the version_constraint: "true" override block (lines 20-21). For packages that are darwin-only across all versions, supported_envs should be placed at the package top level (after description, before version_constraint) to apply globally. The current placement only constrains the specific version override, which could lead aqua to attempt resolution on non-darwin platforms for versions covered by other overrides (e.g., <= 0.1.19).

🔧 Proposed fix: Move supported_envs to top level

   - type: github_release
     repo_owner: ahkohd
     repo_name: oyo
     description: A different viewer
+    supported_envs:
+      - darwin
     version_constraint: "false"
     version_overrides:
       - version_constraint: semver("<= 0.1.19")
         no_asset: true
       - version_constraint: "true"
         asset: oy-{{.Arch}}-{{.OS}}.{{.Format}}
         files:
           - name: oy
         format: tar.gz
         replacements:
           amd64: x86_64
           arm64: aarch64
           darwin: apple-darwin
-        supported_envs:
-          - darwin

Based on learnings: "In pkgs/**/registry.yaml for aquaproj/aqua-registry: This is a very similar case to ahkohd/oyo: it uses version_constraint: 'false' with version_overrides containing no_asset entries AND supported_envs. However, when supported_envs is placed inside version_overrides, it only applies to that specific version constraint, not globally. For darwin-only packages, this placement pattern is non-standard and could lead to resolution attempts on non-darwin environments for versions not explicitly covered."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@pkgs/ahkohd/oyo/registry.yaml` around lines 3 - 21, The supported_envs field
is nested inside the version_overrides block so it only applies to the "true"
override; move supported_envs to the package top level (immediately after
description and before version_constraint) so it applies globally to the
package. Update the registry.yaml so supported_envs is no longer inside the
version_overrides list (remove it from the override that contains
version_constraint: "true") and place a top-level supported_envs: [darwin] field
for the package; keep existing version_overrides (including the semver("<=
0.1.19") no_asset entry and the asset/format/replacements entries) unchanged
except for removing their nested supported_envs.