fix: update apple/container asset name for versions 0.7.0 and later#46443
Closed
preinpost wants to merge 1 commit into
Closed
fix: update apple/container asset name for versions 0.7.0 and later#46443preinpost wants to merge 1 commit into
preinpost wants to merge 1 commit into
Conversation
6cb1430 to
b8ee655
Compare
Member
|
I think the problem has already been solved. |
| version_constraint: "false" | ||
| version_overrides: | ||
| - version_constraint: semver("<= 0.6.0") | ||
| - version_constraint: semver("< 0.7.0") |
Member
There was a problem hiding this comment.
I don't think this change has meaning.
https://github.com/apple/container/releases
Versions:
- 0.7.1
- 0.7.0
- 0.6.0
The evaluation result of <= 0.6.0 and < 0.7.0 are same in this case.
Author
There was a problem hiding this comment.
I verified that it installs correctly using aqua directly (using ref: v4.450.0).
My apologies. The root cause was actually my outdated local environment (I was using mise v2025.8.21). After upgrading mise to the latest version, everything works perfectly.
I saw the error log and hastily assumed the config was broken without checking the existing logic carefully.
Thanks for the review. I'll close this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apple/container - A tool for creating and running Linux containers using lightweight virtual machines on a Mac. It is written in Swift, and optimized for Apple silicon
Check List
Require signed commits, so all commits must be signedcmdx sto scaffold code - Manually updated registry.yaml and tested with local registrySummary
Starting from version 0.7.0, the asset naming convention changed:
Before (≤0.6.0):
container-{version}-installer-signed.pkgAfter (≥0.7.0):
container-installer-signed.pkgThis change adds
version_overridesto support both naming conventions.Install and execute the package and confirm if the package works well