Skip to content

feat: add apache/tomcat#36344

Merged
suzuki-shunsuke merged 2 commits into
aquaproj:mainfrom
murank:feat/apache/tomcat
May 13, 2025
Merged

feat: add apache/tomcat#36344
suzuki-shunsuke merged 2 commits into
aquaproj:mainfrom
murank:feat/apache/tomcat

Conversation

@murank

@murank murank commented May 12, 2025

Copy link
Copy Markdown
Contributor

apache/tomcat: An open source implementation of the Jakarta Servlet, Jakarta Pages, Jakarta Expression Language, Jakarta WebSocket, Jakarta Annotations and Jakarta Authentication specifications

Although Apache Tomcat has a repository on Github, binaries are available only from the official site.

Check List

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label May 12, 2025
@suzuki-shunsuke

suzuki-shunsuke commented May 12, 2025

Copy link
Copy Markdown
Member

Thank you for your contribution!
I'm not familiar with Java and Tomcat at all, so I'm not sure if this works well.

The tarball includes some scripts.

root@386284e32b2d:/workspace# ls /root/.local/share/aquaproj-aqua/pkgs/http/archive.apache.org/dist/tomcat/tomcat-11/v11.0.6/bin/apache-tomcat-11.0.6.tar.gz/apache-tomcat-11.0.6/bin
bootstrap.jar	    ciphers.sh			  daemon.sh	migrate.bat	  shutdown.sh		tool-wrapper.bat
catalina-tasks.xml  commons-daemon-native.tar.gz  digest.bat	migrate.sh	  startup.bat		tool-wrapper.sh
catalina.bat	    commons-daemon.jar		  digest.sh	setclasspath.bat  startup.sh		version.bat
catalina.sh	    configtest.bat		  makebase.bat	setclasspath.sh   tomcat-juli.jar	version.sh
ciphers.bat	    configtest.sh		  makebase.sh	shutdown.bat	  tomcat-native.tar.gz

Now only catalina.sh and catalina.bat are added to $PATH. Is that correct?
Of course, we don't want to add scripts such as version.sh to $PATH because script names are too general.

And do we need to configure environment variables such as CATALINA_HOME?
If we need to configure environment variables depending on this package's installation path, the installation path depends on the package version, so we need to configure the environment variables dynamically.

e.g.

export CATALINA_HOME="$(dirname "$(dirname "$(aqua which catalina.sh)")")"

@murank

murank commented May 13, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for your reply.

I did not add those scripts to $PATH because they are just utilities (e.g. ciphers.sh/bat, digest.sh/bat) or wrappers of catalina.sh/bat (e.g. startup.sh/bat, shutdown.sh/bat) and are not necessary to run the Tomcat server.
The latter may be added to $PATH for convenience, but as you said, their names are too general and I don't want to add them to $PATH either.

The environment variable CATALINA_HOME is automatically set in catalina.sh/bat if not set, so users does not have to set it explicitly.
https://github.com/apache/tomcat/blob/main/bin/catalina.sh#L143

Other environment variables, including JAVA_HOME/JRE_HOME, are set by users and do not depend on the installation path of this package.

The following is part of the result of the Tomcat server with the current registry.yaml and without any explicit environment variables:

$  catalina.sh run
Using CATALINA_BASE:   /root/.local/share/aquaproj-aqua/pkgs/http/archive.apache.org/dist/tomcat/tomcat-11/v11.0.7/bin/apache-tomcat-11.0.7.tar.gz/apache-tomcat-11.0.7
Using CATALINA_HOME:   /root/.local/share/aquaproj-aqua/pkgs/http/archive.apache.org/dist/tomcat/tomcat-11/v11.0.7/bin/apache-tomcat-11.0.7.tar.gz/apache-tomcat-11.0.7
Using CATALINA_TMPDIR: /root/.local/share/aquaproj-aqua/pkgs/http/archive.apache.org/dist/tomcat/tomcat-11/v11.0.7/bin/apache-tomcat-11.0.7.tar.gz/apache-tomcat-11.0.7/temp
Using JRE_HOME:        /usr
Using CLASSPATH:       /root/.local/share/aquaproj-aqua/pkgs/http/archive.apache.org/dist/tomcat/tomcat-11/v11.0.7/bin/apache-tomcat-11.0.7.tar.gz/apache-tomcat-11.0.7/bin/bootstrap.jar:/root/.local/share/aquaproj-aqua/pkgs/http/archive.apache.org/dist/tomcat/tomcat-11/v11.0.7/bin/apache-tomcat-11.0.7.tar.gz/apache-tomcat-11.0.7/bin/tomcat-juli.jar
Using CATALINA_OPTS:
...

@suzuki-shunsuke

Copy link
Copy Markdown
Member

I see. Thank you for your explanation.
I was relieved that it seemed to work well.

@suzuki-shunsuke suzuki-shunsuke added this to the v4.366.1 milestone May 13, 2025
@suzuki-shunsuke suzuki-shunsuke merged commit cc7d923 into aquaproj:main May 13, 2025
19 checks passed
@github-project-automation github-project-automation Bot moved this to Done in main May 13, 2025
@murank murank deleted the feat/apache/tomcat branch May 14, 2025 14:01
@murank murank restored the feat/apache/tomcat branch May 14, 2025 14:01
@suzuki-shunsuke

Copy link
Copy Markdown
Member

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request May 15, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.364.0` -> `v4.367.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary>

### [`v4.367.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.367.0)

[Compare Source](aquaproj/aqua-registry@v4.366.0...v4.367.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.367.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.367.0) | aquaproj/aqua-registry@v4.366.0...v4.367.0

#### 🎉 New Packages

[#&#8203;36413](aquaproj/aqua-registry#36413) [bytecodealliance/wrpc/wit-bindgen-wrpc](https://github.com/bytecodealliance/wrpc) - Wasm component-native RPC framework [@&#8203;AmandaCameron](https://github.com/AmandaCameron)
[#&#8203;36412](aquaproj/aqua-registry#36412) [bytecodealliance/wasm-pkg-tools](https://github.com/bytecodealliance/wasm-pkg-tools) [@&#8203;AmandaCameron](https://github.com/AmandaCameron)
[#&#8203;36410](aquaproj/aqua-registry#36410) [bytecodealliance/wasm-tools](https://github.com/bytecodealliance/wasm-tools) - CLI and Rust libraries for low-level manipulation of WebAssembly modules [@&#8203;AmandaCameron](https://github.com/AmandaCameron)
[#&#8203;36409](aquaproj/aqua-registry#36409) [wasmCloud/wasmCloud/wash](https://github.com/wasmCloud/wasmCloud) - wasmCloud is an open source Cloud Native Computing Foundation (CNCF) project that enables teams to build, manage, and scale polyglot apps across any cloud, K8s, or edge [@&#8203;AmandaCameron](https://github.com/AmandaCameron)

💡 To update `wasmCloud/wasmCloud/wash` using Renovate, please update aqua-renovate-config to 2.8.0 or newer.

https://github.com/aquaproj/aqua-renovate-config/releases/tag/2.8.0

[#&#8203;36393](aquaproj/aqua-registry#36393) [werf/nelm](https://github.com/werf/nelm): Nelm is a Helm 3 alternative. It is a Kubernetes deployment tool that manages Helm Charts and deploys them to Kubernetes
[#&#8203;36344](aquaproj/aqua-registry#36344) [apache/tomcat](https://github.com/apache/tomcat): An open source implementation of the Jakarta Servlet, Jakarta Pages, Jakarta Expression Language, Jakarta WebSocket, Jakarta Annotations and Jakarta Authentication specifications [@&#8203;murank](https://github.com/murank)

#### Fixes

[#&#8203;36380](aquaproj/aqua-registry#36380) Canop/dysk

### [`v4.366.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.366.0)

[Compare Source](aquaproj/aqua-registry@v4.365.0...v4.366.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.366.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.366.0) | aquaproj/aqua-registry@v4.365.0...v4.366.0

#### 🎉 New Packages

[#&#8203;36328](aquaproj/aqua-registry#36328) [ianlewis/todos](https://github.com/ianlewis/todos) - Parse TODO and FIXME comments from code [@&#8203;ianlewis](https://github.com/ianlewis)

#### Fixes

[#&#8203;36333](aquaproj/aqua-registry#36333) crates.io/zizmor: Fix the repository of zizmor

### [`v4.365.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.365.0)

[Compare Source](aquaproj/aqua-registry@v4.364.0...v4.365.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.365.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.365.0) | aquaproj/aqua-registry@v4.364.0...v4.365.0

#### 🎉 New Packages

[#&#8203;36326](aquaproj/aqua-registry#36326) [takumin/zizmor-bin](https://github.com/takumin/zizmor-bin): Static build of `zizmor` [@&#8203;takumin](https://github.com/takumin)
[#&#8203;36313](aquaproj/aqua-registry#36313) [alvinunreal/tmuxai](https://github.com/alvinunreal/tmuxai): AI-Powered, Non-Intrusive Terminal Assistant

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xMS43IiwidXBkYXRlZEluVmVyIjoiNDAuMTEuMTQiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlJlbm92YXRlIEJvdCJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants