Avoid retesting non-viable chunk sizes in tuner#212
Merged
christinaflo merged 1 commit intoMay 28, 2026
Conversation
Contributor
Author
|
@christinaflo PTAL :-) |
Collaborator
|
Hi @GMNGeoffrey, sorry I was out the last week, I'll take a look at these chunking PRs this week! |
The chunk size tuner performs a binary search over chunk sizes, but the existing algorithm only kept track of the lower-bound of the search and so unnecessarily re-tested chunk sizes that had already been proven non-viable. This commit adds more conventional hi/lo tracking to the chunk size search as well as tests for this failure mode.
GMNGeoffrey
force-pushed
the
chunk-tuner-fix-bin-search
branch
from
e49f748 to
1be31e0
Compare
christinaflo
added
the
safe-to-test
Collaborator
|
@GMNGeoffrey what's your preferred order for merging in these PRs? I think this is fine to go in but I've been jumping around a bit and want to check I'm not missing anything |
Contributor
Author
|
I think probably this order: #212, #224, #227 (#231 should be fine to do separately). And then I can test the perf impact of #213. But I don't think it matters too much. Whatever seems good to go, you can go ahead and merge. I'll need to resolve some merge conflicts regardless (I think I consciously set myself up for some in #227 because I wanted to steal the tests from this PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The chunk size tuner performs a binary search over chunk sizes, but the existing algorithm only kept track of the lower-bound of the search and so unnecessarily re-tested chunk sizes that had already been proven non-viable.
Changes
Related Issues
Fixes #211
Testing
Added unit tests for this case and confirmed they failed with the old implementation.