[core] AptosConnect Telegram support #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardsetting
requested review from
0xmaayan,
kaw2k and
kent-white
as code owners
hardsetting
force-pushed
the
gabriele/ac-telegram-support
branch
from
f397331
to
a2bdd56
Compare
0xmaayan
approved these changes
Oct 6, 2024
| @@ -30,6 +30,7 @@ | |||
| "@radix-ui/react-slot": "^1.0.2", | |||
| "@radix-ui/react-switch": "^1.0.3", | |||
| "@radix-ui/react-toast": "^1.1.5", | |||
| "@telegram-apps/sdk": "^2.0.0", | |||
There was a problem hiding this comment.
In CAD we use '@telegram-apps/sdk-react' - is it a different package?
There was a problem hiding this comment.
It's the same underlying package (although I'm using v2 here)
'react-sdk' builds on top of 'sdk'
There was a problem hiding this comment.
didn't need full react support
Joj501
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/aptos-labs/aptos-connect/pull/624
Nothing required from dapp developers other than bumping to the latest version of the Wallet Adapter.
Screen.Recording.2024-10-05.at.5.02.18.PM.mov