Upgrade packages and update cicd #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidiw
commented
Jan 5, 2025
davidiw
commented
- Update all packages to latest versions
- Cleanup any issues
- Make sure CICD is as clean as it can be
python now requires version 3.9 or greater removed tomli, I guess it was a temporary requirement
banool
approved these changes
Jan 6, 2025
| @@ -24,6 +24,7 @@ lint: | |||
| examples: | |||
| poetry run python -m examples.aptos_token | |||
| poetry run python -m examples.fee_payer_transfer_coin | |||
| poetry run python -m examples.multikey | |||
| @@ -64,6 +64,8 @@ async def main( | |||
| alice, large_package_example_dir, large_packages_account | |||
| ) | |||
|
|
|||
| await rest_client.close() | |||
There was a problem hiding this comment.
Nit, can we use the client as a context manager? The indentation is annoying though...
davidiw
force-pushed
the
fixup
branch
5 times, most recently
from
2a2a2ad to
cf0d19c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.